1794552 - Reorganize Marionette component for the "Remote Protocol" product

Status: RESOLVED FIXED

(Remote Protocol :: Marionette, task, P1)

Description

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Follow-up from bug 1792742.

Given that most of the failures are usually coming from Marionette and not geckodriver the WebDriver related wpt tests should be handled by the "Testing / Marionette" component.

mach file-info bugzilla-component testing/web-platform/tests/webdriver/tests/
Testing :: geckodriver
  testing/web-platform/tests/webdriver/tests/

Instead it should be listed as Testing / Marionette.

Hereby I wonder if we should create a Remote Protocol / Marionette component for the JS side of Marionette and leave Testing / Marionette for the client and harness.

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+2]]

As discussed in today's triage meeting we will make the above changes including a new Remote Protocol / Marionette componentand renaming the existing component toTesting :: Marionette Client / Harness`. This will also involve moving existing open bugs over to the new component.

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+2]]

(In reply to Henrik Skupin (:whimboo) [⌚️UTC+1] from comment #1)

As discussed in today's triage meeting we will make the above changes including a new Remote Protocol / Marionette componentand renaming the existing component toTesting :: Marionette Client / Harness`. This will also involve moving existing open bugs over to the new component.

The necessary work here should actually happen on its own bug. I'll file a dedicated one in a moment.

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+2]]

While creating the simple patch for this bug I noticed that it might not be a good idea to get this landed and do the follow-up work on a different bug. As such lets rename the bug's summary so that we can get it all done here. I might have to get other bugs filed as well (eg. the creation of Remote Protocol / Marionette which will block this one.

Here are the steps that need to be done:

• [x] Send out a governance email which describes all the planned changes covered by the following bullet points.
• [x] Move the Testing / Marionette component to Remote Protocol / Marionette and update its description so that it's clear it's now about the server (JavaScript) side of the protocol.
• [x] Create a new Testing / Marionette Client & Harness (better name?) component and set owners and peers.
• [x] Move all Marionette client and harness related bugs to the newly created component (should be way lesser than the JS related bugs).
• [ ] Update the Bugzilla component for WebDriver classic tests so that it points to Remote Protocol / Marionette and move intermittent failures from Testing / geckodriver.
• [x] Update owners / peers of components under Remote Protocol and make sure that both Julian and Sasha are listed as peers.
• [x] Check various external dashboards / query links to be still functional for Marionette

Comment 4

[Henrik Skupin [:whimboo][⌚️UTC+2]]

After talking to :mossop we found a couple of inconsistencies in the module system documentation that he is going to fix over the next week. As such we should wait with making this change until everything has been cleaned-up.

Comment 5

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Once bug 1791070 has been fixed we can get started with out reorganization.

Comment 6

[Henrik Skupin [:whimboo][⌚️UTC+2]]

We should not forget to also update the Wiki pages that can be found eg. at https://wiki.mozilla.org/WebDriver/Marionette.

Comment 7

[Henrik Skupin [:whimboo][⌚️UTC+2]]

The email to governance has been sent out:
https://groups.google.com/a/mozilla.org/g/governance/c/BsRYD6VWqS8

If there are no objections I will come up with the patch by latest Thursday.

Comment 8

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Attachment: Bug 1794552 - Add James and Sasha as peers for Remote Protocol components.

Comment 9

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Attachment: Bug 1794552 - Reorganize modules for Remote Protocol.

Depends on D169092

Comment 10

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Attachment: Bug 1794552 - [marionette] Fix Bugzilla components for Marionette related files.

Depends on D169093

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1ad8e1ce1ef0
Add James and Sasha as peers for Remote Protocol components. r=zeid DONTBUILD
https://hg.mozilla.org/integration/autoland/rev/5065bb912bf4
Reorganize modules for Remote Protocol. r=zeid DONTBUILD
https://hg.mozilla.org/integration/autoland/rev/be4daab7c1d2
[marionette] Fix Bugzilla components for Marionette related files. r=webdriver-reviewers,Sasha,jgraham DONTBUILD

Comment 12

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/1ad8e1ce1ef0
https://hg.mozilla.org/mozilla-central/rev/5065bb912bf4
https://hg.mozilla.org/mozilla-central/rev/be4daab7c1d2

Comment 13

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Reopening because it's not done yet. I still have to move bugs around that do not apply to the right component. Also we have to wait for bug to be completed.

Comment 14

[Henrik Skupin [:whimboo][⌚️UTC+2]]

We actually missed to update the following line so that wdspec tests for classic are still referred to the geckodriver component:
https://searchfox.org/mozilla-central/rev/611660bff9e6d52f1769bf216a7fbd12ece4d2d2/testing/web-platform/moz.build#724

I'll have patch later today.

Comment 15

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Attachment: Bug 1794552 - [marionette] Update Bugzilla component for public webdriver tests to Marionette.

Comment 16

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f5c50b239f3e
[marionette] Update Bugzilla component for public webdriver tests to Marionette. r=webdriver-reviewers,Sasha DONTBUILD

Comment 17

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/f5c50b239f3e