1794597 - [wayland] Bookmark toolbar folders located on the left side of the window have a misaligned drop location during drag operations

Status: VERIFIED FIXED

(Core :: Widget: Gtk, defect, P3)

Description

[Kestrel]

Attachment: Video of bookmark drop location being offset from cursor for popups near left window edge

STR:

1. Start with MOZ_ENABLE_WAYLAND=1 on Ubuntu 22.04.
2. Create a bookmark toolbar folder with a long list of items.
3. Position the folder on the left-most side of the toolbar.
4. Open the folder and drag bookmarks around, dropping them over the lower-right region of the popup.

Bug 1791539 fixed the drop indicator position but the actual drop location is still offset.

Comment 1

[Martin Stránský [:stransky] (ni? me)]

That's interesting, thanks.

Comment 2

[Martin Stránský [:stransky] (ni? me)]

Attachment: Bug 1794597 [Wayland] Apply popup drop position workaround to both drag motion and drag drop operations r?emilio

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d95a8118fcb3
[Wayland] Apply popup drop position workaround to both drag motion and drag drop operations r=emilio

Comment 4

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/d95a8118fcb3

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:stransky, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox107 to wontfix.

For more information, please visit auto_nag documentation.

Comment 6

[Martin Stránský [:stransky] (ni? me)]

Comment on attachment 9299181 [details]
Bug 1794597 [Wayland] Apply popup drop position workaround to both drag motion and drag drop operations r?emilio

Beta/Release Uplift Approval Request

• User impact if declined: Wrong drop position when bookmarks are dropped.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): This patch sync D&D handlers - we have correct fix in move handler only and we add it to drop handler too.
• String changes made/needed:
• Is Android affected?: No

Comment 7

[Donal Meehan [:dmeehan]]

Comment on attachment 9299181 [details]
Bug 1794597 [Wayland] Apply popup drop position workaround to both drag motion and drag drop operations r?emilio

Approved for 107.0b3.

Comment 8

[Donal Meehan [:dmeehan]]

https://hg.mozilla.org/releases/mozilla-beta/rev/1d2cdafde8ec

Comment 9

[Giorgia Nichita, Release Desktop QA]

Reproduced this issue on an affected Nightly build from 2022-010-11, on Ubuntu 22.04 with Wayland enabled.
Verified as fixed on Firefox 107.0b3 (20221020202724) and 108.0a1 (20221021083918).