Closed
Bug 1794644
Opened 2 years ago
Closed 2 years ago
Remove macOS 10.9-11 shared_lock workaround from rlbox
Categories
(Core :: Security: RLBox, task)
Core
Security: RLBox
Tracking
()
RESOLVED
FIXED
107 Branch
Tracking | Status | |
---|---|---|
firefox107 | --- | fixed |
People
(Reporter: nika, Assigned: nika)
References
Details
Attachments
(2 files)
When rlbox was added, a special case was added to rlbox_config.h (https://searchfox.org/mozilla-central/rev/f118dae98073bc17efb8604a32abfcb7b4e05880/config/external/rlbox/rlbox_config.h#11-30) to use the mozilla StaticRWLock
type on macos in order to avoid a lack of support for the c++17 shared_lock
type.
We only support macOS 10.12+ today, so this workaround can be removed.
Assignee | ||
Comment 1•2 years ago
|
||
Depends on D158886
Assignee | ||
Comment 2•2 years ago
|
||
The original use in rlbox which made having this annotation impossible is no
longer necessary as it was removed in the previous part.
Depends on D159084
Pushed by nlayzell@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/95166f6b5412 Part 1: Remove rlbox shared lock workaround for macOS 10.{9-11}, r=glandium https://hg.mozilla.org/integration/autoland/rev/bd9ba9c35115 Part 2: Mark `StaticRWLock` as `MOZ_ONLY_USED_TO_AVOID_STATIC_CONSTRUCTORS`, r=xpcom-reviewers,kmag
Comment 4•2 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/95166f6b5412
https://hg.mozilla.org/mozilla-central/rev/bd9ba9c35115
Status: NEW → RESOLVED
Closed: 2 years ago
status-firefox107:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 107 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•