1794657 - Remove the main-thread-only host->policy map from ExtensionPolicyService

Status: RESOLVED FIXED

(WebExtensions :: General, enhancement)

Description

[Nika Layzell [:nika] (ni? for response)]

In https://phabricator.services.mozilla.com/D158884, kmag mentioned that he'd be comfortable getting rid of the main thread copy of the table if we made the threadsafe version of the table be guarded by an RWLock.

This will require the changes in bug 1794644 to allow the StaticRWLock type to be used more generally.

Comment 1

[Nika Layzell [:nika] (ni? for response)]

Attachment: Bug 1794657 - Part 1: Use a StaticRWLock in the ExtensionPolicyService, r=kmag!

Depends on D159085

Comment 2

[Nika Layzell [:nika] (ni? for response)]

Attachment: Bug 1794657 - Part 2: Remove the main-thread-only host map from ExtensionPolicyService, r=kmag!

We're still holding strong references to the WebExtensionPolicy objects through
the mExtensions map, so we don't need to worry about the policy instances
dying earlier after this change.

Depends on D159086

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/18fab9aeb0ec
Part 1: Use a StaticRWLock in the ExtensionPolicyService, r=kmag
https://hg.mozilla.org/integration/autoland/rev/639c1a648ed7
Part 2: Remove the main-thread-only host map from ExtensionPolicyService, r=kmag

Comment 4

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/18fab9aeb0ec
https://hg.mozilla.org/mozilla-central/rev/639c1a648ed7