Closed Bug 1795106 Opened 2 months ago Closed 21 days ago

CC subtitles are not displayed inside the PiP window on TubiTv

Categories

(Toolkit :: Picture-in-Picture, defect)

Desktop
Windows 10
defect

Tracking

()

VERIFIED FIXED
108 Branch
Tracking Status
firefox-esr102 --- wontfix
firefox105 --- wontfix
firefox106 --- wontfix
firefox107 --- wontfix
firefox108 --- verified

People

(Reporter: rares.doghi, Assigned: kpatenio)

References

(Blocks 2 open bugs)

Details

Attachments

(3 files)

Attached image PIPSubs.png

Found in

  • 107.0a1 (2022-10-13)

Affected versions

  • Firefox Nightly 107.0a1
  • Beta 106.0b9
  • Release 105.0.3

Affected platforms

  • Windows, Mac

Steps to reproduce

  1. Connect To US on any VPN.
  2. Reach https://tubitv.com/tv-shows/541230/s01-e01-secret-garden?start=true and play Episode 1.
  3. Enter PiP mode.
  4. Enable CC subtitles

Expected result

  • Subtitles should be displayed inside the PiP window.

Actual result

  • The CC Subtitles are only displayed in the Main Window.
Has STR: --- → yes
Attached video 2022-10-14_15h13_19.mp4

This is also reproducible on nytimes.com/video. Subtitles are not displayed inside the PiP window.

This issue also occurs in 97.0a1 (2021-12-30).

Took a peek at the DOM for Tubi videos. The captions container was apparently updated to use a data attribute data-id. Our original script relied on finding a div with an id = "captionsComponent". It seems that all we need to do is update the script to observe the proper element.

Assignee: nobody → kpatenio
Status: NEW → ASSIGNED
Pushed by kpatenio@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/608da48a7005
updated tubitv script for PiP cc and subs support. r=pip-reviewers,niklas
Status: ASSIGNED → RESOLVED
Closed: 21 days ago
Resolution: --- → FIXED
Target Milestone: --- → 108 Branch

Verified as fixed in our latest Nightly build 108.0a1 (2022-11-08).

The patch landed in nightly and beta is affected.
:kpatenio, is this bug important enough to require an uplift?

  • If yes, please nominate the patch for beta approval.
  • If no, please set status-firefox107 to wontfix.

For more information, please visit auto_nag documentation.

Flags: needinfo?(kpatenio)
Flags: needinfo?(kpatenio)

Updating Status Flag.

Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.