1795106 - CC subtitles are not displayed inside the PiP window on TubiTv

Status: VERIFIED FIXED

(Toolkit :: Picture-in-Picture, defect)

Description

[Rares Doghi, Desktop QA]

Attachment: PIPSubs.png

Found in

• 107.0a1 (2022-10-13)

Affected versions

• Firefox Nightly 107.0a1
• Beta 106.0b9
• Release 105.0.3

Affected platforms

• Windows, Mac

Steps to reproduce

1. Connect To US on any VPN.
2. Reach https://tubitv.com/tv-shows/541230/s01-e01-secret-garden?start=true and play Episode 1.
3. Enter PiP mode.
4. Enable CC subtitles

Expected result

• Subtitles should be displayed inside the PiP window.

Actual result

• The CC Subtitles are only displayed in the Main Window.

Comment 1

[Alin Ilea, Desktop Test Engineering]

Attachment: 2022-10-14_15h13_19.mp4

This is also reproducible on nytimes.com/video. Subtitles are not displayed inside the PiP window.

Comment 2

[Rares Doghi, Desktop QA]

This issue also occurs in 97.0a1 (2021-12-30).

Comment 3

[kpatenio]

Took a peek at the DOM for Tubi videos. The captions container was apparently updated to use a data attribute data-id. Our original script relied on finding a div with an id = "captionsComponent". It seems that all we need to do is update the script to observe the proper element.

Comment 4

[kpatenio]

Attachment: Bug 1795106 - updated tubitv script for PiP cc and subs support. r=#pip-reviewers!

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/608da48a7005
updated tubitv script for PiP cc and subs support. r=pip-reviewers,niklas

Comment 6

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/608da48a7005

Comment 7

[Rares Doghi, Desktop QA]

Verified as fixed in our latest Nightly build 108.0a1 (2022-11-08).

Comment 8

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:kpatenio, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox107 to wontfix.

For more information, please visit auto_nag documentation.

Comment 9

[Rares Doghi, Desktop QA]

Updating Status Flag.