1795176 - `Today` highlighting in Month view does not update when the date changes at midnight

Status: RESOLVED FIXED

(Calendar :: Calendar Frontend, defect)

Description

[Thomas D. (:thomas8)]

See https://support.mozilla.org/en-US/questions/1392559

Seen on 102.3.3 (and already seen in 102.3.0), 64bit, Win11.
Alice, is this a regression as the support ticket seems to suggest?

STR

• Calendar, choose Month view (important, seems to work in other views).
• Set system clock to 23:59 on current day
• Observe today highlighting and try Go to today after date changes at midnight to next day

Actual

• Today highlighting (blue color etc.) does not move to the new day after midnight, i.e. wrong/stale day is presented as Today
• Go to Today also fails to update Today highlighting.

Expected

• Update Today highlighting after midnight
• Go to Today must go to the new current date.

Comment 1

[Thomas D. (:thomas8)]

Alex, this is pretty odd. Afasics only restarting TB will update Today in Month view.

Comment 2

[Alice0775 White]

(In reply to Thomas D. (:thomas8) from comment #0)

Actual

• Today highlighting (blue color etc.) does not move to the new day after midnight, i.e. wrong/stale day is presented as Today

Reproduced in Thunderbird 102.3.2.
And reproduced even in Thunderbird 78.0beta1 , 102.0beta1 as well as Daily 107.0a1(20221013103729). ---> this seems NOT A REGRESSION

• Go to Today also fails to update Today highlighting.

WORKS FOR ME in Thunderbird 102.3.2 as well as Daily 107.0a1(20221013103729).

Comment 3

[Geoff Lankow (:darktrojan)]

This works for me.

The timer that runs it logs if calendar.debug.log and calendar.debug.log.verbose are on. You can also run CalMetronome.on("minute", console.log) in the console to see if it's working or "day" instead of "minute" to see the daily event if you expect it. Time is not designed to run backwards so if you change the system clock backwards the timer will break.

Comment 4

[Alessandro Castellani [:aleca]]

I can't seem to reproduce this issue either.

Comment 5

[Geoff Lankow (:darktrojan)]

I finally figured out what caused this. Still duping this bug to the older one.

Comment 6

[Geoff Lankow (:darktrojan)]

Actually, not that one.

Comment 7

[Geoff Lankow (:darktrojan)]

Attachment: Bug 1795176 - Ensure that the 'today' box is updated in the month view. r=#thunderbird-front-end-reviewers

Comment 8

[Geoff Lankow (:darktrojan)]

It's probably bug 1753558 that caused it. Seems like a good enough scapegoat.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/1a09aa855dbb
Ensure that the 'today' box is updated in the month view. r=freaktechnik

Comment 10

[Geoff Lankow (:darktrojan)]

Comment on attachment 9298728 [details]
Bug 1795176 - Ensure that the 'today' box is updated in the month view. r=#thunderbird-front-end-reviewers

[Approval Request Comment]
Regression caused by (bug #): probably bug 1753558? who knows
User impact if declined: day marked as today doesn't move in the month view
Testing completed (on c-c, etc.): landed this week
Risk to taking this patch (and alternatives if risky): low

Comment 11

[Wayne Mery (:wsmwk)]

Comment on attachment 9298728 [details]
Bug 1795176 - Ensure that the 'today' box is updated in the month view. r=#thunderbird-front-end-reviewers

[Triage Comment]
Approved for beta

Comment 12

[Rob Lemley [:rjl]]

Thunderbird 107.0b2:
https://hg.mozilla.org/releases/comm-beta/rev/b854be2d4cb2

Comment 13

[Wayne Mery (:wsmwk)]

Comment on attachment 9298728 [details]
Bug 1795176 - Ensure that the 'today' box is updated in the month view. r=#thunderbird-front-end-reviewers

[Triage Comment]
Approved for esr102

Comment 14

[Rob Lemley [:rjl]]

Thunderbird 102.4.2:
https://hg.mozilla.org/releases/comm-esr102/rev/3c37987b3154