1753558 - Upgrade main calendar views to use CalFilterMixin instead of CalendarViewRefreshJob

Status: RESOLVED FIXED

(Calendar :: Calendar Frontend, enhancement)

Description

[Geoff Lankow (:darktrojan)]

In bug 1727711 I built a new component for getting events from the calendars to the UI. I connected it to the Today Pane agenda, and it's been there long enough now that I'm confident it's good. In this bug I'll connect it to the main calendar views (day, week, multi-week, month).

Comment 1

[Geoff Lankow (:darktrojan)]

Attachment: Bug 1753558 - Make CalendarBaseView a subclass of CalendarFilterMixin. r=henry

This ties the calendar views to the calendars via CalFilterMixin instead of via CalendarViewRefreshJob and fixes a few related oddities along the way.

Some changes to calFilter were necessary to enable showing only incomplete tasks without causing a bit mess.
Some changes to CalFilterMixin were made so that tests can get a Promise which resolves when a view has finished loading items. This will be improved in a following patch.

Comment 2

[Geoff Lankow (:darktrojan)]

Attachment: Bug 1753558 - Improve the ready Promise in CalFilterMixin. r=henry

The Promise introduced in the last patch should reject if something causes the view to be invalid while it is still loading. This could happen if the date of the view changes or a refresh is forced.

Depends on D139251

Comment 3

[Geoff Lankow (:darktrojan)]

Attachment: Bug 1753558 - Rename CalFilterMixin to CalendarFilterMixin and use private members in it. r=henry

I've decided I don't like the abbreviated name CalendarFilterMixin. And we should use private members to avoid cluttering subclasses and potentially causing issues.

Depends on D139252

Comment 4

[Geoff Lankow (:darktrojan)]

Attachment: Bug 1753558 - Remove unused calIDecoratedView. r=#thunderbird-reviewers

We don't use this file. It's just lying around, not referenced anywhere.

Comment 5

[Geoff Lankow (:darktrojan)]

Attachment: Bug 1753558 - Improve calFilter for new uses. r=henry

To use calFilter on the main calendar views, we need to be able to specify whether or not completed tasks are included.
However we need to preserve the old functionality until we can replace the task lists.

Depends on D139446

Comment 6

[Geoff Lankow (:darktrojan)]

Attachment: Bug 1753558 - Improve CalFilterMixin for new uses. r=henry

I've added a Promise which resolves when all items from all calendars have loaded, or rejects if the loading becomes invalid by the parameters changing. This will help speed up tests by removing an arbitrary wait time on each view load.

I renamed it from CalFilterMixin to CalendarFilterMixin as that seems a better fit. And all of the private members are now properly private to avoid cluttering up subclasses.

Depends on D139447

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/45455c783e96
Remove unused calIDecoratedView. r=john.bieling

Comment 8

[Geoff Lankow (:darktrojan)]

I knew that would happen. :-(

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/d4a1a26aad21
Improve calFilter for new uses. r=henry
https://hg.mozilla.org/comm-central/rev/91720fcc1778
Improve CalFilterMixin for new uses. r=henry

Comment 10

[Geoff Lankow (:darktrojan)]

Attachment: Bug 1753558 - Drop showDaysOutsideMonth in CalendarMonthBaseView. r=henry

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/c48d5def07a6
Drop showDaysOutsideMonth in CalendarMonthBaseView. r=henry

Comment 12

[Geoff Lankow (:darktrojan)]

One of these days I'm going to learn about the leave-open keyword and when to use it.

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/79b9ea2e5932
Make CalendarBaseView a subclass of CalendarFilterMixin. r=henry

Comment 14

[Geoff Lankow (:darktrojan)]

Attachment: Bug 1753558 - Fix calendar filter handling of tasks that change completion status. r=henry

The item type filter was matching all tasks, even if we only wanted incomplete tasks.

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/0c4ad7b846e2
Fix calendar filter handling of tasks that change completion status. r=henry