Closed Bug 17952 Opened 20 years ago Closed 20 years ago
Can't do window
.set Timeout() or window .close() when attempted by way of xpconnect
We're between worlds (broken JSContext overloading, fixed XPConnect ThreadJSContextStack usage) and it sucks. We need to move the DOM state that's mislocated in JSContext into the window object private, reparameterize as needed and stuff. I'll help. /be
This depends on (is sort of a duplicate of) bug 17736
Bill, I believe this should be fixed with my xpconnect refactoring that went in today. The similar bug 17736 is fixed. I'm reasigning this to you. Could you please run whatever test you have - if it is not too difficult to set that up - and either mark it fixed or reassign to me if there is still a problem.
I'll check it out (will have to change JS that was modified to bypass the problem). The setTimeout() started working a little while back but unfortunately caused a crash when it did window.close(). window.close() in a xpconnect invoked JS method was not working and may with this most recent fix.
Is this fixed in M13? If so, its TM need not be M14. Just curious, /be
The problem is fixed. I just verified it on Mac and Linux (each of which had window closing quirks till recently). I have not reset the code in downloadProgress.js. I've got some other bug fixes in that file and am waiting for a code review to be completed. I hope to check that code in later today. I'm resetting this to M13 so I'll remember to close this one, too, after the code is checked in.
Status: ASSIGNED → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
JS code has been reverted to use the technique that was previously causing the problem. Everything looks good now.
is bug 49138 a dup of this? If so, something has regressed.
You need to log in before you can comment on or make changes to this bug.