1795296 - OffscreenCanvas should try to use Direct2D backend if possible

Status: RESOLVED FIXED

(Core :: Graphics: Canvas2D, enhancement, P3)

Description

[Andrew Osmond [:aosmond] (he/him)]

We appear to not try to use the Direct2D backend, because we actually need an HTMLCanvasElement to get the WindowRenderer:

https://searchfox.org/mozilla-central/rev/50d8456970a33fde950ec483b46ffd324f79c0b5/dom/canvas/CanvasRenderingContext2D.cpp#1560

The code doesn't look to actively require access to the WindowRenderer (WebRenderLayerManager) so we can probably make a decision for worker threads.

I haven't done an exhaustive analysis so there may be more globals that we need to make threadlocal or add mutex protection for.

Comment 1

[Andrew Osmond [:aosmond] (he/him)]

The foundation will be laid in bug 1855742 and we can enable it here / update tests.

Comment 2

[Andrew Osmond [:aosmond] (he/him)]

Attachment: Bug 1795296 - Enable Direct2D backend with OffscreenCanvas.

Depends on D189532

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/05b607c3bbe6
Enable Direct2D backend with OffscreenCanvas. r=gfx-reviewers,lsalzman

Comment 4

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/05b607c3bbe6

Comment 5

[Noemi Erli[:noemi_erli]]

Backed out 12 changesets (Bug 1795296, Bug 1855742) as requested by aosmond a=backout
Link: https://hg.mozilla.org/mozilla-central/rev/3fd71c45d9fc05e5912ec6c9ba191a9a3a7f2038

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/223489055d61
Enable Direct2D backend with OffscreenCanvas. r=gfx-reviewers,lsalzman

Comment 7

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/223489055d61