Closed Bug 1795335 Opened 2 years ago Closed 2 years ago

Search engine icons are cut off

Categories

(Firefox :: Search, defect, P3)

Firefox 107
Desktop
Windows 10
defect

Tracking

()

VERIFIED FIXED
108 Branch
Tracking Status
firefox-esr102 --- unaffected
firefox106 --- unaffected
firefox107 --- disabled
firefox108 --- verified

People

(Reporter: alice0775, Assigned: emilio)

References

(Regression)

Details

(Keywords: nightly-community, regression)

Attachments

(2 files)

Attached image screencast

Steps to reproduce:

  1. Install a lot of search engine
  2. Enable Standalone Search bar
  3. Click Magnifying glass in Standalone Search bar

Actual results:
Search engine icons are cut off. See attached screenshot.

Expected Results:
All icons should be visible.

Regression window:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=48c266f64c004b63ce578243d3e5a82c9540e308&tochange=fb32775d2defaa2fe7d6e270aefc31d80b3f729a

Assignee: nobody → emilio

The interaction of legacy flexbox (menupopup) with block is a bit nicer
than with flex.

I'm going to update menupopup with modern flexbox as soon as I fix all
the browser-chrome tests and the soft freeze is over, but this is
harmless and fixes the bug both with and without modern flexbox.

Remove -moz-box-flex: 0; from search-panel-tree since it's now useless
(there's no flexing to do since parent isn't a flex container).

Set 107 to disabled, regressor bug 1790616 backed out of central

Severity: -- → S2
Priority: -- → P3
Pushed by ealvarez@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/7f762ef403e2
Use `display: block` for search autocomplete popup. r=dao
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → 108 Branch

I am unable to reproduce the issue on the mentioned build (Fx 107.0a1). The issue also doesn't occur for me in the latest Fx 108.0a1 on Windows 10 (on a 1440p monitor, if it matters).

Alice, could you please help us with a confirmation here that the issue has been fixed?

Flags: needinfo?(alice0775)

I managed to reproduce this issue in Nightly107.0a1(20221014095137).
And I can confirm that the issue is no longer reproduced in Nightly108.0a1(20221026224258) and Firefox106.0b5.

Status: RESOLVED → VERIFIED
Flags: needinfo?(alice0775)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: