1795346 - Refactor MobileTabBrowser (and WindowManager) so that tabs are handled as tabs and not windows on Android

Status: NEW

(Remote Protocol :: Agent, task, P3)

Description

[Julian Descottes [:jdescottes]]

The "tab" variant of the type_hint test actually doesn't throw, it's just that we cannot assert window handles in the same way as for desktop.

Basically after opening a new tab on Android, we will still actually open a window, so we can't really verify that the type_hint was respected. Nevertheless we could adapt the assertion so that it doesn't fail on Android (sidenote: the cross browser type.py test already covers this, so we already have coverage).

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Given that Firefox on Android uses windows as tabs and also present the different browsers as tabs internally we should handle that the same way and let MobileTabBrowser return a list of tabs, even when these are actually windows. This might require some refactoring to make the WindowManager ready for Android as well.

I'm updating the summary to reflect the actual required changes.

Comment 2

[Julian Descottes [:jdescottes]]

(In reply to Henrik Skupin (:whimboo) [⌚️UTC+2] from comment #1)

Given that Firefox on Android uses windows as tabs and also present the different browsers as tabs internally we should handle that the same way and let MobileTabBrowser return a list of tabs, even when these are actually windows. This might require some refactoring to make the WindowManager ready for Android as well.

I'm updating the summary to reflect the actual required changes.

Note that this will not necessarily help with the test for which I filed this bug testing/web-platform/mozilla/tests/webdriver/bidi/browsing_context/create/type_hint.py

If I follow correctly, the suggestion is that:

• TabManager should treat the Android windows as tabs
• WindowManager should return a single window on Android when retrieving chromeWindowHandles

The second statement is the one needed to make the test pass without having to update the asserts. However, I can't see which window we should return in that case. Do we have a top level window that would make sense to return here?