1765619 - Support the context parameter for browsingContext.create

Status: RESOLVED FIXED

(Remote Protocol :: WebDriver BiDi, task, P1)

Description

[Julian Descottes [:jdescottes]]

The context parameter is proposed at https://github.com/w3c/webdriver-bidi/pull/153

It allows to specify a reference context for browsingContext.create. When type "tab" is used the new context should share the same OS window as the reference context.

This bug is about adding the implementation for this parameter, but we should at least wait until the spec PR is close to be accepted to move forward.

Comment 1

[Julian Descottes [:jdescottes]]

Attachment: Bug 1765619 - [webdriver-bidi] Add context parameter to browsingContext.create command

Depends on D143650

Comment 2

[Julian Descottes [:jdescottes]]

Attachment: Bug 1765619 - [webdriver] Support context parameter context for browsing context create

Depends on D143651

Comment 3

[Julian Descottes [:jdescottes]]

Attachment: Bug 1765619 - [wdspec] Update wdspec tests for the browsingContext.create context parameter

Depends on D143652

Comment 4

[Julian Descottes [:jdescottes]]

Attachment: Bug 1765619 - [webdriver-bidi] Add gecko specific webdriver test for browsingContext.create context argument

Depends on D143653

Comment 5

[Henrik Skupin [:whimboo][⌚️UTC+2]]

The PR got merged so this bug is no longer blocked. Julian, do you want to continue working on it?

Comment 6

[Julian Descottes [:jdescottes]]

I will at least rebase and update the patches to match the PR, we can discuss if that should be in m5 then.

Comment 7

[Julian Descottes [:jdescottes]]

Attachment: Bug 1765619 - [remote] Add referenceTab parameter to TabManager addTab

The updated version of the browsingContext.create spec mentions that the new tab should be added right after the reference context when
provided. We need to extend TabManager.addTab in order to support this behavior:

Comment 8

[Julian Descottes [:jdescottes]]

Attachment: Bug 1765619 - [remote] Add getTabForBrowsingContext helper in TabManager

Depends on D159121

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f497dc5418fb
[remote] Add referenceTab parameter to TabManager addTab r=webdriver-reviewers,Sasha,whimboo
https://hg.mozilla.org/integration/autoland/rev/bfcad162f26d
[remote] Add getTabForBrowsingContext helper in TabManager r=webdriver-reviewers,whimboo
https://hg.mozilla.org/integration/autoland/rev/d9ddc65fcb38
[webdriver-bidi] Add context parameter to browsingContext.create command r=webdriver-reviewers,Sasha,whimboo
https://hg.mozilla.org/integration/autoland/rev/744c82b97d76
[webdriver] Support context parameter context for browsing context create r=webdriver-reviewers,Sasha,whimboo
https://hg.mozilla.org/integration/autoland/rev/6f36f9508aa4
[wdspec] Update wdspec tests for the browsingContext.create context parameter r=webdriver-reviewers,whimboo
https://hg.mozilla.org/integration/autoland/rev/9335bd19ed0d
[webdriver-bidi] Add gecko specific webdriver test for browsingContext.create context argument r=webdriver-reviewers,whimboo

Comment 10

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/36466 for changes under testing/web-platform/tests

Comment 11

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/f497dc5418fb
https://hg.mozilla.org/mozilla-central/rev/bfcad162f26d
https://hg.mozilla.org/mozilla-central/rev/d9ddc65fcb38
https://hg.mozilla.org/mozilla-central/rev/744c82b97d76
https://hg.mozilla.org/mozilla-central/rev/6f36f9508aa4
https://hg.mozilla.org/mozilla-central/rev/9335bd19ed0d

Comment 12

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot