1795547 - File > Offline > Download/Sync Now ... doesn't download messages before going offline in NNTP-JS

Status: RESOLVED FIXED

(MailNews Core :: Networking: NNTP, defect)

Description

[b4]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/106.0.0.0 Safari/537.36

Steps to reproduce:

File > Offline > Download/Sync Now ... doesn't download messages before going offline in NNTP-JS

Have a newsgroup that is selected for offline use.
Go offline using "File > Offline > Download/Sync Now ..." and select newsgroup messages.

Actual results:

After going offline, not all newsgroups have been downloaded. In fact, when switching to the old C++ module, it's quite visible in the status bar that messages are downloaded, not so for the JS module.

Expected results:

Messages should have been downloaded for offline use.

Comment 1

[Alfred Peters [:infofrommozilla]]

(In reply to b4 from comment #0)

After going offline, not all newsgroups have been downloaded. In fact, when switching to the old C++ module, it's quite visible in the status bar that messages are downloaded, not so for the JS module.

Confirmed for Release and Daily.

Comment 2

[Ping Chen [:rnons] (away)]

OK, I forgot to implement nsINntpService.downloadNewsgroupsForOffline, will rewrite nsNewsDownloader.cpp in JS.

Comment 3

[Ping Chen [:rnons] (away)]

Attachment: Bug 1795547 - Support downloading all news before going offline. r=mkmelin

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/bf9dd95a17f3
Support downloading all news before going offline. r=mkmelin

Comment 5

[b5]

Attachment: 1795547-download-news-before-offline.patch (ESR 102 version)

Comment 6

[b5]

Attachment: news-setup.png

Can you please look at this again, it's not quite working like in the C++ module.

1. First and foremost, the "Work offline once download and/or sync is complete" option doesn't work.
2. Secondly, at least from the status bar display it appears to be downloading newsgroups which weren't selected for offline use.
3. It also appears to re-download certain messages, maybe those are expired articles, there are 4 on a.d.test. That also happens in the C++ module.
4. Further to one, when going offline because automatically going offline doesn't work, there is a whole lot of activity in NGs not selected for offline use. According to the status bar display, all the headers appear to be downloaded again.

Another issue which is unrelated to this bug but related to offline use in general is that clicking a NG which wasn't selected for offline use while in offline use causes an hourglass to be displayed.

In the current state, offline news reading isn't really usable.

If you want to reproduce our testing, see the subscribed newsgroups in the attached screenshot.

Comment 7

[Ping Chen [:rnons] (away)]

Attachment: Bug 1795547 - Download articles for newsgroup set for offline use only. r=mkmelin

Comment 8

[Ping Chen [:rnons] (away)]

"Work offline once download and/or sync is complete" seems to work for me, please try again.

2 and 4 seems to be the same, the new patch should fix them.

Another issue which is unrelated to this bug but related to offline use in general is that clicking a NG which wasn't selected for offline use while in offline use causes an hourglass to be displayed.

Let me fix this separately. Thanks.

Comment 9

[b5]

(In reply to Ping Chen (:rnons) from comment #8)

"Work offline once download and/or sync is complete" seems to work for me, please try again.

Yes, this works on 102 with part 1 applied (attachment 9300953 [details] [diff] [review]) and Daily with a small setup, one small newsgroup. It likely didn't work on our test setup (comment #6) since downloading of the NGs which weren't meant to be downloaded never ended (issue 2 & 4). We'll test again with part 2 applied.

2 and 4 seems to be the same, the new patch should fix them.

Thank you.

Another issue which is unrelated to this bug but related to offline use in general is that clicking a NG which wasn't selected for offline use while in offline use causes an hourglass to be displayed.

Let me fix this separately. Thanks.

Will you file a bug?

Comment 10

[b5]

Attachment: 1795547-download-news-before-offline.patch (ESR 102 version, merge of both patches)

(In reply to b5 from comment #9)

We'll test again with part 2 applied.

This appears to be working now with 1. also resolved. Merged ESR 102 version attached for your convenience.

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/4de95d512152
Download articles for newsgroup set for offline use only. r=mkmelin

Comment 12

[Rob Lemley [:rjl]]

Comment on attachment 9300904 [details]
Bug 1795547 - Support downloading all news before going offline. r=mkmelin

[Triage Comment]
Approved for beta in consideration for esr102. Note to uplifter: two changesets to uplift.

[Approval Request Comment]
Regression caused by (bug #): nntp-js
User impact if declined: NNTP messages are not synced prior to going offline
Testing completed (on c-c, etc.): By Betterbird devs
Risk to taking this patch (and alternatives if risky):

Comment 13

[Rob Lemley [:rjl]]

Comment on attachment 9301291 [details] [diff] [review]
1795547-download-news-before-offline.patch (ESR 102 version, merge of both patches)

[Approval Request Comment]
Regression caused by (bug #): nntp-js
User impact if declined: NNTP messages are not synced prior to going offline
Testing completed (on c-c, etc.): By Betterbird devs
Risk to taking this patch (and alternatives if risky):

Ping - any objections? This patch is from an outside contributor and should be reviewed again.

Comment 14

[Daniel Darnell [:dandarnell]]

Thunderbird 107.0b4:
https://hg.mozilla.org/releases/comm-beta/rev/7f62db5f63bd

Comment 15

[Daniel Darnell [:dandarnell]]

Thunderbird 107.0b4:
https://hg.mozilla.org/releases/comm-beta/rev/67e71050806c

Comment 16

[Wayne Mery (:wsmwk)]

Comment on attachment 9301291 [details] [diff] [review]
1795547-download-news-before-offline.patch (ESR 102 version, merge of both patches)

[Triage Comment]
Approved for esr102

Comment 17

[Rob Lemley [:rjl]]

Thunderbird 102.5.0:
https://hg.mozilla.org/releases/comm-esr102/rev/ec41e10e46fb