1795597 - MV2 extensions should never flag for attention

Status: RESOLVED FIXED

(WebExtensions :: General, defect)

Description

[Tomislav Jovanovic :zombie]

This is just the attention flag part of bug 1794427, the status message will be still be incorrect.

Comment 1

[Tomislav Jovanovic :zombie]

Attachment: Bug 1795597 - MV2 extensions should never flag for attention, r=willdurand

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/803c38deeee5
MV2 extensions should never flag for attention, r=willdurand

Comment 3

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/803c38deeee5

Comment 4

[BugBot [:suhaib / :marco]]

Set release status flags based on info from the regressing bug 1777343

Comment 5

[William Durand [:willdurand]]

Comment on attachment 9298786 [details]
Bug 1795597 - MV2 extensions should never flag for attention, r=willdurand

Beta/Release Uplift Approval Request

• User impact if declined: Currently, beta/dev edition users (with add-ons installed) seem to be affected. Release users might also be affected in the future.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce: QA is not strictly required but, just in case, there are STR in Bug 1796061, which describes the issue that we'd like to fix by uplifting the patch to beta.
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): The change in itself is simple: it checks the manifest version and only shows the "attention dot" on MV3 extensions. Users cannot install MV3 extensions at the moment, which is why this patch effectively fixes the problem described in Bug 1796061.

In addition, the change is covered by tests.

• String changes made/needed: None
• Is Android affected?: No

Comment 6

[Donal Meehan [:dmeehan]]

Comment on attachment 9298786 [details]
Bug 1795597 - MV2 extensions should never flag for attention, r=willdurand

Approved for 107.0b3.

Comment 7

[Donal Meehan [:dmeehan]]

https://hg.mozilla.org/releases/mozilla-beta/rev/eb042722b273