1796061 - Attention "dot" for the Unified extensions UI should not be visible when the pref is disabled

Status: RESOLVED DUPLICATE of bug 1795597

(WebExtensions :: General, defect)

Description

[William Durand [:willdurand]]

Attachment: Screenshot 2022-10-19 at 09.09.46.png

STR

1. install FF dev edition (107.0b2)
2. install an add-on like Tree Style Tab
3. browser mozilla.org

What happened?

The Tree Style Tab extension button in the toolbar has a green "attention dot".

Expected

No attention dot should be visible because the unified extensions UI shouldn't be enabled in channels other than Nightly.

Explanations

The attention dot has been implemented in browser/components/extensions/parent/ext-browserAction.js and we didn't check the pref here.

Comment 1

[Pascal Chevrel (relman team) -> :pascalc]

Donal, fyi we will need an uplift to prevent that in 107.

Comment 2

[William Durand [:willdurand]]

Attachment: Bug 1796061 - Attention "dot" for the Unified extensions UI should not be visible when the pref is disabled. r?zombie

Comment 3

[William Durand [:willdurand]]

After having discussed with :zombie, we'll probably want to request an uplift of the patch for Bug 1795597

Comment 4

[William Durand [:willdurand]]

To expand a bit on my last comment and the initial report, it turns out that we have two "MV3 UIs":

• "origin controls" that is very small and not very visible to end users, indirectly controlled by the MV3 pref (that is enabled in Nightly and Early Beta)
• "unified extensions" that is more visible, also related to origin controls (but in a more obvious way) and controlled by a different pref (that is only enabled in Nightly)

The UI bug reported in here belongs to the first UI and that's why we are going to fix this bug with Bug 1795597 rather than checking the unified extensions pref. See uplift request here: https://bugzilla.mozilla.org/show_bug.cgi?id=1795597#c5

Comment 5

[Donal Meehan [:dmeehan]]

Resolving as a duplicate of Bug 1795597 (fixed in 107 and 108)