1795609 - Search Page bar (from Ctrl+F) not clearing search error message

Status: VERIFIED FIXED

(Toolkit :: Find Toolbar, defect)

Description

[Mark]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:107.0) Gecko/20100101 Firefox/107.0

Steps to reproduce:

Scenario 1:

Hit Ctrl+F to bring up the Search Page bar. Key in something that is not on the page. The message, "Phrase not found", is displayed. But now backspace to delete that text and replace it with something that occurs multiple times on the page, and now one sees something like "1 of 3 matches Phrase not found". (The "Phrase not found" should have been removed once the edited search term matches what is on the page.)

Scenario 2:

Hit Ctrl+F to bring up the Search Page bar. Key in something that occurs multiple times on the page. Hit V (find next) to get to the last match on the web page, and hit it again to display the fist match on the page. The message, "Reached end of page, continued from the top", is displayed. But hit V (find next) again to view the second match on the page, the message, "Reached end of page, continued from the top", is still displayed even though it should have been removed.

Actual results:

The "Phrase not found" or "Reached end of page, continued from the top" message is still displayed when it should have been removed.

Mozregression-gui stops at:

2022-10-16T13:43:36.291000: DEBUG : Found commit message: Bug 1792464 - Convert findbar.properties to Fluent. r=NeilDeakin,fluent-reviewers,flod

Differential Revision: https://phabricator.services.mozilla.com/D158768

2022-10-16T13:43:36.291000: DEBUG : Did not find a branch, checking all integration branches 2022-10-16T13:43:36.291000: INFO : The bisection is done. 2022-10-16T13:43:36.291000: INFO : Stopped

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Toolkit::Find Toolbar' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Comment 2

[Alice0775 White]

[Tracking Requested - why for this release]:

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

:eemeli, since you are the author of the regressor, bug 1792464, could you take a look? Also, could you set the severity field?

For more information, please visit auto_nag documentation.

Comment 4

[Eemeli Aro [:eemeli]]

Attachment: Bug 1795609 - Properly clear findbar status. r=NeilDeakin!

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a9eddbd2a0a7
Properly clear findbar status. r=NeilDeakin

Comment 6

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/a9eddbd2a0a7

Comment 7

[Donal Meehan [:dmeehan]]

:eemeli could you add a beta uplift request when you're ready?

Comment 8

[Eemeli Aro [:eemeli]]

Comment on attachment 9298803 [details]
Bug 1795609 - Properly clear findbar status. r=NeilDeakin!

Beta/Release Uplift Approval Request

• User impact if declined: The findbar status text will not be cleared properly after having been set.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Very small change affecting only the findbar status indicator text
• String changes made/needed: none
• Is Android affected?: No

Comment 9

[Donal Meehan [:dmeehan]]

Comment on attachment 9298803 [details]
Bug 1795609 - Properly clear findbar status. r=NeilDeakin!

Approved for 107.0b2.

Comment 10

[Donal Meehan [:dmeehan]]

https://hg.mozilla.org/releases/mozilla-beta/rev/e147c9a0fda3

Comment 11

[Emil Ghitta, QA [:emilghitta]]

Reproduced both scenarios from comment 0 using Firefox 107.0a1 (BuildId:20221016093143).

This issue is verified fixed using Firefox 108.0a1 (BuildId: 20221018213916) and 107.0b2 (BuildId:20221018185850) on Windows 10 64bit, macOS 11 and Ubuntu 22.

During the verification of this issue, I've noticed that both the previous match number and the "Phrase not found" strings are displayed for a second when interacting with the find in previous or find in next buttons. Filled under Bug 1796078