1796078 - Both previous match number and "Phrase not found" are displayed for a short period of time

Status: VERIFIED FIXED

(Toolkit :: Find Toolbar, defect)

Description

[Emil Ghitta, QA [:emilghitta]]

Attachment: findBar.gif

Found in

• Firefox 107.0b2 (BuildId:20221018185850)

Affected versions

• Firefox 108.0a1 (BuildId: 20221018213916)
• Firefox 107.0b2 (BuildId:20221018185850)

Tested platforms

• Affected platforms: Windows 10 64bit, macOS 11 & Ubuntu 22

Steps to reproduce

1. Access the following webpage.
2. Hit ctrl + f.
3. Type "enf".
4. Hit enter or click on the ^ V (find in previous or find in next).

Expected result

• The "Phrase not found" is displayed.

Actual result

• Both "1 of 8 matches" (which comes from the "en" search) and the "Phrase not found" strings are displayed for a second.

Regression range

• This seems to be a regression. Will provide asap.

Comment 1

[Bogdan Maris, Desktop QA]

Using mozregression it pointed to https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=a94ad0477229c32639861e6ae0d4367150a3e713&tochange=a2f1f50e1a972f57d269b6a0eaba51d3f01bfe62

Regressor bug 1792464 - Convert findbar.properties to Fluent

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

The bug is marked as tracked for firefox107 (beta). However, the bug still isn't assigned and has low severity.

:yshash, could you please find an assignee and increase the severity for this tracked bug? Given that it is a regression and we know the cause, we could also simply backout the regressor. If you disagree with the tracking decision, please talk with the release managers.

For more information, please visit auto_nag documentation.

Comment 3

[Eemeli Aro [:eemeli]]

Attachment: Bug 1796078 - Fix remaining flashes of invalid content in findbar status. r=NeilDeakin!

I was not able to come up with solid automated test for these changes, as that would need to rely on catching the DOM in the middle of a couple of async updates.

Some checkbox/statuslabel updates are included here, as the previous implementation was producing console warnings.

Comment 4

[Donal Meehan [:dmeehan]]

:enndeakin, seems :eemeli is on PTO until RC week. Could you or someone else review/land this patch?

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0c70b459ca9e
Fix remaining flashes of invalid content in findbar status. r=NeilDeakin

Comment 6

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/0c70b459ca9e

Comment 7

[Eemeli Aro [:eemeli]]

Comment on attachment 9299732 [details]
Bug 1796078 - Fix remaining flashes of invalid content in findbar status. r=NeilDeakin!

Beta/Release Uplift Approval Request

• User impact if declined: Some incorrect text may be very briefly visible to users when using the findbar
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Very small change affecting only the findbar status indicator
• String changes made/needed:
• Is Android affected?: No

Comment 8

[Donal Meehan [:dmeehan]]

Comment on attachment 9299732 [details]
Bug 1796078 - Fix remaining flashes of invalid content in findbar status. r=NeilDeakin!

Approved for 107.0b9

Comment 9

[Donal Meehan [:dmeehan]]

https://hg.mozilla.org/releases/mozilla-beta/rev/8bb180dab9f7

Comment 10

[Emil Ghitta, QA [:emilghitta]]

This issue is verified fixed using Firefox 107.0b9 (BuildId:20221103190044) and Firefox 108.0a1 (BuildId:20221103214316) on Windows 10 64bit, Ubuntu 22.04 and macOS 11

Comment 11

[Yasmin S]

clearing need info as this has been assigned / fixed