1795650 - The colors of the icons from the status bar are not in contrast with the status bar background color

Status: UNCONFIRMED

(Fenix :: General, defect)

Description

[iorgamgabriel]

Attachment: Screenshot_20221012-171234.png

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/106.0.0.0 Safari/537.36

Steps to reproduce:

1. From Gmail open a link on a custom tab or open a custom tab from Focus itself.
2. The icons from status bar are not visible for light theme and for dark theme are not in contrast .
   This bug it is in Focus and Fenix . 106 version
   It was added first here https://github.com/mozilla-mobile/focus-android/issues/7860

Actual results:

The icons from status bar are not visible for light theme and for dark theme are not in contrast .

Expected results:

The colors of the icons from the status bar should be in contrast with the status bar background color.

Comment 1

[iorgamgabriel]

Attachment: Screenshot_20221012-154938.png

Comment 2

[iorgamgabriel]

The problem is in Android Component support-ktx modul WindowInsetsControllerCompat should be different than the status background color.

Comment 3

[sbucc]

I can confirm this, version info:
106.1.0 (Build #2015909131), 71ca6c1f7+
AC: 106.0.5, 5f06485fc3
GV: 106.0-20221010181815
AS: 94.2.1

I use the light theme and the icons are white on white.
Switching to another tab and back fixes this: the text colour turns dark grey.
Switching to another app and back to Firefox brings back white on white.

It seems there is a check to define the notification bar text color that is executed correctly when switching between tabs, but it is skipped when Firefox becomes the active app.

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:cpeterson, could you have a look please?

For more information, please visit auto_nag documentation.

Comment 5

[Iorga Gabriel]

This bug was fixed https://github.com/mozilla-mobile/focus-android/issues/7860

Comment 6

[Makoto Kato [:m_kato]]

(In reply to Iorga Gabriel from comment #5)

This bug was fixed https://github.com/mozilla-mobile/focus-android/issues/7860

If not using dark mode, it will be fixed.

Unfortunately, I can reproduce same issue on Twitter's PWA when using the latest version of Firefox Nightly (on Pixel 6a + Android 13) with dark mode. Twitter's manifest.json has theme_color: "#ffffff", so background color of status bar is white. But status icon keeps white. I guess that this may be a bug of custom tab feature in android framework.