1795704 - Add-ons are only displayed in English

Status: RESOLVED FIXED

(GeckoView :: Extensions, defect, P1)

Description

[Makoto Kato [:m_kato]]

From github: https://github.com/mozilla-mobile/fenix/issues/27298.

Steps to reproduce

1. Set the language of the device or Firefox to something other than English.
2. Add a multilingual add-on (e.g. uBlock Origin).
3. View the add-on's settings screen.

Expected behaviour

If the add-on supports the selected language, it will be displayed in the selected language.

Actual behaviour

Add-on settings are only displayed in English, no matter what language it is set to.

Device name

Sharp AQUOS R3

Android version

Android 11

Firefox release type

Firefox Nightly

Firefox version

107.0a1 (Build #2015908203)

Device logs

No response

Additional information

A same issue has occurred pieviously in Fennec F-Droid.
In both cases, Application Settings in about:support page is only en-US.

┆Issue is synchronized with this Jira Task

Change performed by the Move to Bugzilla add-on.

Comment 1

[Makoto Kato [:m_kato]]

mozregression says,

 3:50.80 INFO: Last good revision: a58c99b9307bd575ce241b8fd4dff29b14b5e0b4
 3:50.80 INFO: First bad revision: 6b3649e1c4672fa35a3a39225c97272a8700d166
 3:50.80 INFO: Pushlog:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=a58c99b9307bd575ce241b8fd4dff29b14b5e0b4&tochange=6b3649e1c4672fa35a3a39225c97272a8700d166

But I don't think that this is regression by bug 1792544. Does other changes causes this issue?

Comment 2

[Kevin Brosnan [Ex-Mozilla]]

[Tracking Requested - why for this release]: Extensions are no longer localized for some/all? users.

Comment 3

[Makoto Kato [:m_kato]]

It seems to be package is broken after a58c99b9307bd575ce241b8fd4dff29b14b5e0b4. Localized files are missing. I suspect that this issue is same root case as bug 1792258.

Comment 4

[Makoto Kato [:m_kato]]

Also, another problem is that <input date>'s rendering is broken. en-US is "mm/dd/yyyy" and ja is "yyyy/mm/dd", but Fenix Nightly shows "mm/dd/yyyy" even if ja locale.

Comment 5

[Eemeli Aro [:eemeli]]

(In reply to Makoto Kato [:m_kato] from comment #4)

Also, another problem is that <input date>'s rendering is broken. en-US is "mm/dd/yyyy" and ja is "yyyy/mm/dd", but Fenix Nightly shows "mm/dd/yyyy" even if ja locale.

That might be a regression from bug 1734221.

Comment 6

[Francesco Lodolo [:flod]]

Not related to this, but still a packaging problem: I don't think we're not packaging all the files that we should.
https://searchfox.org/mozilla-central/source/mobile/android/locales/filter.py

In the APK I can only see 3 ftl files (brand, aboutcrashes, aboutWebrtc). This means that a bunch of pages are in English, when they shouldn't (about:mozilla, about:support to name a couple).

Comment 7

[BugBot [:suhaib / :marco]]

Setting Regressed by field after analyzing regression range found by mozregression in comment #1.

Comment 8

[BugBot [:suhaib / :marco]]

:dimi, since you are the author of the regressor, bug 1792544, could you take a look? Also, could you set the severity field?

For more information, please visit auto_nag documentation.

Comment 9

[Marco Castelluccio [:marco]]

Given comment 1, removing bug 1792544 from "Regressed By". I filed https://github.com/mozilla/relman-auto-nag/issues/1695 to make the bot not set the "Regressed By" field if the regressionwindow-wanted keyword is present.

Comment 10

[Makoto Kato [:m_kato]]

(In reply to Eemeli Aro [:eemeli] from comment #5)

That might be a regression from bug 1734221.

I guess that converting to FTL causes comment #4 issue. But I don't reproduce it on 106.b5, so this issue is something packaging bug for FTL files.

Comment 11

[Donal Meehan [:dmeehan]]

Has there been any further investigation into this?
It was triaged to P1 S3 but not assigned.
Tracking it for 107 as requested in comment 2, but wondering who is looking into it?

Comment 12

[BugBot [:suhaib / :marco]]

The bug is marked as tracked for firefox107 (beta) and tracked for firefox108 (nightly). However, the bug still isn't assigned and has low severity.

:cpeterson, could you please find an assignee and increase the severity for this tracked bug? If you disagree with the tracking decision, please talk with the release managers.

For more information, please visit auto_nag documentation.

Comment 13

[Makoto Kato [:m_kato]]

Probably, this is regression by bug 1786186 . jar.mn change by bug 1786186 will cause this issue. Also, that fix is broken since aboutConfig.ftl isn't copied to $(objdir)/dist/bin/localization/en-us/mobile/android.

Nick is working on that fix by bug 1792258. I hope that this issue will be fixed by bug 1792258.

Comment 14

[Chris Peterson [:cpeterson]]

(In reply to Makoto Kato [:m_kato] from comment #13)

Nick is working on that fix by bug 1792258. I hope that this issue will be fixed by bug 1792258.

In that case, I will tentatively assign this bug to Nick since his fix for bug 1792258 will hopefully also fix this bug.

Comment 15

[BugBot [:suhaib / :marco]]

Setting Regressed by field after analyzing regression range found by mozregression in comment #1.

Comment 16

[BugBot [:suhaib / :marco]]

Set release status flags based on info from the regressing bug 1792544

Comment 17

[Makoto Kato [:m_kato]]

Ah, bot is false operation...

Comment 18

[Francesco Lodolo [:flod]]

Bug 1792258 landed, but it doesn't look like it affected this bug.

Comment 19

[Francesco Lodolo [:flod]]

One thing to note is that "Internationalization & Localization" is completely empty in Nightly, but it has plenty of values in release.

I don't know enough of Fenix to know if that's expected, because the two pages look quite different (other tables are empty, e.g. Accessibility).

Comment 20

[Nick Alexander :nalexander [he/him] (PTO August 22-September 12)]

There are two problems here; see https://bugzilla.mozilla.org/show_bug.cgi?id=1792258#c35 and https://bugzilla.mozilla.org/show_bug.cgi?id=1792258#c36. We've fixed about:config, and we just landed patches to address the rest of the multi-locale packaging. If those work, then this should be restored.

Comment 21

[Eemeli Aro [:eemeli]]

Could someone verify that the reproduction steps do provide a localized add-on settings experience on 106 or earlier? In my own testing (Android 13 on Pixel 7, Finnish locale), I observe the following in both 106.1.0 and yesterday's Nightly:

• The add-on descriptions are properly localized where available.
• The add-on settings are only presented in English.

On Desktop, the add-on settings are properly localized at least on Firefox 106.0.5 (macOS 12.5 on M1).

Comment 22

[Francesco Lodolo [:flod]]

(In reply to Eemeli Aro [:eemeli] from comment #21)

Could someone verify that the reproduction steps do provide a localized add-on settings experience on 106 or earlier? In my own testing (Android 13 on Pixel 7, Finnish locale), I observe the following in both 106.1.0 and yesterday's Nightly:

• The add-on descriptions are properly localized where available.
• The add-on settings are only presented in English.

Take uBlock origin as an example: both the Settings page and Info panel are localized in Italian. You can probably test it by switching to a larger language like French or German in the app.

Comment 23

[Francesco Lodolo [:flod]]

Attachment: uBlock Settings

This screenshot is from 106.1.0

Comment 24

[Donal Meehan [:dmeehan]]

(In reply to Nick Alexander :nalexander [he/him] from comment #20)

There are two problems here; see https://bugzilla.mozilla.org/show_bug.cgi?id=1792258#c35 and https://bugzilla.mozilla.org/show_bug.cgi?id=1792258#c36. We've fixed about:config, and we just landed patches to address the rest of the multi-locale packaging. If those work, then this should be restored.

Both of the fixes for the problems mentioned here have been uplifted to 107. (Bug 1799002 and Bug 1792258)
Fenix 107.1.0 is available on the alpha channel and includes these fixes.
Please Note: Bug 1799002 has not landed in central yet, the uplift to 107 was a very specific fix but with a more complete fix to land in central for 108

Comment 25

[Eemeli Aro [:eemeli]]

Attachment: uBlock Settings in French on 107.1.0

(In reply to Francesco Lodolo [:flod] from comment #22)

Take uBlock origin as an example: both the Settings page and Info panel are localized in Italian. You can probably test it by switching to a larger language like French or German in the app.

(In reply to Donal Meehan [:dmeehan] from comment #24)

Fenix 107.1.0 is available on the alpha channel and includes these fixes.

Ah, thanks. Was mislead by the partial Finnish localization; I do see the French localized add-on settings on 106.1.0, and now that I found 107.1.0 via APKMirror, also there. 107.06b and the latest Nightly present English add-on settings.

Donal, is there a better way to access this "alpha channel"?

Comment 26

[Donal Meehan [:dmeehan]]

Donal, is there a better way to access this "alpha channel"?

:eemeli, QA has access to the alpha channel for Firefox release versions. They test on Alpha before it gets promoted to the Production channel.
I'll send you a DM

Comment 27

[Donal Meehan [:dmeehan]]

Setting 107 as fixed, see comment 24 and confirmation in comment 25.

Comment 28

[Ryan VanderMeulen [:RyanVM]]

Flod, can you confirm that 108/109 are working as expected? We worked around bug 1799002 by reverting the regressing change until Nick's refactoring in that bug is ready to land, so as far as I know this should all be working correctly at this point across all channels.

Comment 29

[Francesco Lodolo [:flod]]

Both nightly and beta are working correctly at the moment.

Comment 30

[Ryan VanderMeulen [:RyanVM]]

Thanks, calling this fixed by bug 1792258 and the backout of bug 1791878 then. We'll want to double-check that the problem doesn't return after bug 1799002 gets fixed and bug 1791878 re-lands.