1795752 - Sign in/sign up to FxA should use entrypoint=fx-view

Status: VERIFIED FIXED

(Firefox :: Firefox View, defect)

Description

[Sam Foster [:sfoster] (he/him)]

We currently build a URL to open the sign-in/signup to FxA tab using "firefoxview" as the entry point. That should be "fx-view".

i.e. https://accounts.firefox.com/?context=fx_desktop_v3&entrypoint=firefoxview&action=email&service=sync
vs.
https://accounts.firefox.com/?context=fx_desktop_v3&fx-view=firefoxview&action=email&service=sync

This bug doesn't appear to impact end-user functionality, but it complicates/confuses reporting etc. on the backend.

Comment 1

[Sam Foster [:sfoster] (he/him)]

Attachment: Bug 1795752 - Use fx-view rather than firefoxview as the entry point param for FxA signin/signup. r?Gijs!

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d734d1d10478
Use fx-view rather than firefoxview as the entry point param for FxA signin/signup. r=Gijs

Comment 3

[Cristian Tuns]

Backed out for causing mochitest failures on browser_feature_callout.js

• Backout link
• Push with failures
• Failure Log
• Failure line: TEST-UNEXPECTED-FAIL | browser/components/firefoxview/tests/browser/browser_feature_callout.js | Test timed out -

Comment 4

[Sam Foster [:sfoster] (he/him)]

Thanks for the backout - it didn't occur to me to go looking for a test that relied on this detail.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/83cd5e5f031c
Use fx-view rather than firefoxview as the entry point param for FxA signin/signup. r=Gijs

Comment 6

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/83cd5e5f031c

Comment 7

[Sam Foster [:sfoster] (he/him)]

Comment on attachment 9298898 [details]
Bug 1795752 - Use fx-view rather than firefoxview as the entry point param for FxA signin/signup. r?Gijs!

Beta/Release Uplift Approval Request

• User impact if declined: None, impact is to reporting.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: Verify that clicking the "Continue" button to sign in to Fxa on firefox view loads https://accounts.firefox.com/ with an entrypoint=firefoxview querystring param
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): No functional changes, single line change that only affects firefox view.
• String changes made/needed: None
• Is Android affected?: No

Comment 8

[Sam Foster [:sfoster] (he/him)]

Leif, i'm told this should be on your radar as it may have an impact on FxA reporting. My understanding is that firefox view was opening the FxA page with an incorrect entrypoint querystring param, which would mean they might show up as originating from the appmenu.

Comment 9

[Leif Oines [:loines]]

We were definitely seeing some data coming from entrypoint=firefoxview before, as seen in this chart.

But thanks for flagging me, I can update the dashboards to look for either entrypoint value now.

Comment 10

[Donal Meehan [:dmeehan]]

Comment on attachment 9298898 [details]
Bug 1795752 - Use fx-view rather than firefoxview as the entry point param for FxA signin/signup. r?Gijs!

Approved for 107.0b2.

Comment 11

[Donal Meehan [:dmeehan]]

https://hg.mozilla.org/releases/mozilla-beta/rev/778d253ebcb6

Comment 12

[Sam Foster [:sfoster] (he/him)]

Comment on attachment 9298898 [details]
Bug 1795752 - Use fx-view rather than firefoxview as the entry point param for FxA signin/signup. r?Gijs!

Beta/Release Uplift Approval Request

• User impact if declined: None, impact is to reporting.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: Verify that clicking the "Continue" button to sign in to Fxa on firefox view loads https://accounts.firefox.com/ with an entrypoint=firefoxview querystring param
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): No user-visible functional changes, single line change that only affects firefox view and how FxA sign up page loads are attributed.
• String changes made/needed: None
• Is Android affected?: No

Comment 13

[Sam Foster [:sfoster] (he/him)]

Comment on attachment 9298898 [details]
Bug 1795752 - Use fx-view rather than firefoxview as the entry point param for FxA signin/signup. r?Gijs!

Looks like this patch doesnt apply cleanly on 106. I'll prepare a new patch.

Comment 14

[Sam Foster [:sfoster] (he/him)]

Attachment: bug-1795752-v106.diff

This the same as attachment 9298898 [details], but some refactoring in there since 106 meant it didn't apply cleanly. This does the same thing.

Try push: https://treeherder.mozilla.org/jobs?repo=try&revision=e63fa18e1a45a32b5419923e1648a212954a8faf

Beta/Release Uplift Approval Request

• User impact if declined: None, impact is to reporting.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: Verify that clicking the "Continue" button to sign in to Fxa on firefox view loads https://accounts.firefox.com/ with an entrypoint=firefoxview querystring param
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): No user-visible functional changes, single line change that only affects firefox view and how FxA sign up page loads are attributed.
• String changes made/needed: None
• Is Android affected?: No

Comment 15

[Gabi Cheta [:Gabi] Desktop QA]

Verified that the issue is fixed in Firefox 107.0b2 and Firefox 108.0a1 across platforms (Windows 10x64, Ubuntu 18.4 and macOS 10.12.6).
Marking the issue Fx106-affected based on the previous comments.

Comment 16

[Ray Fambro]

[Tracking Requested - why for this release]:

Would like to ensure that we are capturing accurate data with our telemetry. The sooner we can make this update, the better.
@Sam - Can you give a perspective on the level of risk associated with uplifting?

Comment 17

[Sam Foster [:sfoster] (he/him)]

(In reply to Ray Fambro from comment #16)

[Tracking Requested - why for this release]:

Would like to ensure that we are capturing accurate data with our telemetry. The sooner we can make this update, the better.
@Sam - Can you give a perspective on the level of risk associated with uplifting?

This is on the low end of low risk from the desktop perspective. Its a small patch, no tricky logic or gotchas and easy to unambiguously verify. We should get the FxA folks to confirm this fixes their reporting gap however.

Comment 18

[Ray Fambro]

Thanks Sam! Pulling in Vesta to continue the thread.

Comment 19

[Pascal Chevrel:pascalc]

Comment on attachment 9299182 [details] [diff] [review]
bug-1795752-v106.diff

Approved for 106.0.2

Comment 20

[Pascal Chevrel:pascalc]

https://hg.mozilla.org/releases/mozilla-release/rev/2c0c975ad800

Comment 21

[Gabi Cheta [:Gabi] Desktop QA]

Verified as fixed with Firefox 106.0.2 Windows 10x64, macOS 10.12.6 and Ubuntu 20.4.