1784363 - Update the URL opened by the fxview "Get Firefox for mobile" buttons to use ?entrypoint=fx-view

Status: RESOLVED FIXED

(Firefox :: Firefox View, task, P1)

Description

[Sam Foster [:sfoster] (he/him)]

Bug 1783892 change the "Get firefox for mobile" buttons in Firefox View to open FxA instead of the sync section in Preferences. But we needed to temporarily use an existing "entrypoint=fxa_app_menu" parameter. Adding a more appropriate "fx-view" entrypoint is tracked in https://mozilla-hub.atlassian.net/browse/FXA-5729. Once that is live, we can update the TabsSetupFlowManager.openFxAPairDevice method to request the correct url from the fxAccounts module.

Comment 1

[:Gijs (he/him)]

Apparently because of how bmo-jira sync works we can't have the fxa ticket in the "see also" field and also expect to track this ticket in FIDEFE. So, I'm removing https://mozilla-hub.atlassian.net/browse/FXA-5729 and have added it to the URL field instead.

Comment 2

[Kelly Cochrane [:kcochrane]]

Hey this is a P1 bug, but no one is assigned to it, so it's showing in triage. Is there someone who can take this?

Comment 3

[Sarah Clements [:sclements]]

Attachment: WIP Bug 1784363 - Update the fxa entrypoint to use fx-view r=Gijs

Comment 4

[Sarah Clements [:sclements]]

Attachment: Screenshot 2022-08-31 at 14.44.14.png

This is the modal that is displayed if I changed the fxa entrypoint to fx-view, after selecting the "Get firefox for mobile" button in the mobile promo.

But this doesn't match what I see in the figma. Am I looking in the wrong place? Josh, can you please confirm this is correct?

Comment 5

[Sarah Clements [:sclements]]

Jihwan, Ray mentioned you're the UX designer for fxa. Were you involved in designing the fx-view entrypoint for Firefox View? If so, can you please confirm this is correct before I the switch to this entry point. Please see my comment above.

Comment 6

[Wil Clouser [:clouserw]]

Support for the fx-view parameter on FxA will be live on https://accounts.stage.mozaws.net/ this afternoon for testing and should be in production next Wednesday afternoon (Sep 7)

Comment 7

[Josh Berman]

I'm going to let Jihwan speak to this one and clear the needs info on me. Feel free to pull me back in if you need me.

Comment 8

[Sarah Clements [:sclements]]

(In reply to Wil Clouser [:clouserw] from comment #6)

Support for the fx-view parameter on FxA will be live on https://accounts.stage.mozaws.net/ this afternoon for testing and should be in production next Wednesday afternoon (Sep 7)

Ok, I'll hold off on merging this pr until this is in production. Can you please let me know when its been deployed? Or if there's a github issue I can follow, that is fine too.

Comment 9

[Jihwan Kim]

Attachment: Fx-view

Users coming from FxA toolbar, Sync settings, or after completing the sign-up/sign-in flow (entrypoint=fxa_app_menu)
Note*: The footer copy might be changed. Vesta to confirm.

Comment 10

[Jihwan Kim]

Attachment: Fx-view Updated

Footer copy is now "Not now" which directs users to the FX Accounts page.

Comment 11

[Wil Clouser [:clouserw]]

(In reply to Sarah Clements [:sclements] from comment #8)

Ok, I'll hold off on merging this pr until this is in production. Can you please let me know when its been deployed? Or if there's a github issue I can follow, that is fine too.

https://bugzilla.mozilla.org/show_bug.cgi?id=1788288

Comment 12

[Sarah Clements [:sclements]]

Attachment: Screenshot 2022-09-08 at 11.00.45.png

Per the bug 1788288 the most recent changes for the fx-view entrypoint have been deployed to production, but I still see the same as asset as in comment 4.

Jihwan, I thought in our slack conversion last week we were talking about the asset for the fx-view entry point specifically, but I noticed in comment 8 you were referring to the existing fxa_app_menu that we're using. Can someone please clarify what asset and entry point we're supposed to be using?

Comment 13

[Wil Clouser [:clouserw]]

bug 1788288 is still open and this is not in production yet. We expect to close the bug (and put this in production) today.

Comment 14

[Sarah Clements [:sclements]]

(In reply to Wil Clouser [:clouserw] from comment #13)

bug 1788288 is still open and this is not in production yet. We expect to close the bug (and put this in production) today.

ok, thanks for the update.

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/dcc1646d1352
WIP Bug 1784363 - Update the fxa entrypoint to use fx-view r=Gijs

Comment 16

[Cristina Cozmuta (:CrissCozmuta)]

https://hg.mozilla.org/mozilla-central/rev/dcc1646d1352