1795756 - Enable NumberFormat v3

Status: RESOLVED FIXED

(Core :: JavaScript: Internationalization API, task, P3)

Description

[Greg Tatum [:gregtatum]]

This was implemented in Bug 1763607, but is currently Nightly-only. This bug is for tracking enabling the features. I didn't see another one already filed.

Comment 1

[André Bargull [:anba]]

Attachment: Bug 1795756 - Part 1: Update ToIntlMathematicalValue to apply exponent limits. r=dminor!

Apply the Intl mathematical value limits from [1] to our code. The minimum and
maximum exponents are now limited by Number.MIN_VALUE resp. Number.MAX_VALUE,
which are both way below our previous limit of 9'999'999.

Also removes the BigInt exponent check, because JS::BigInt::MaxDigitLength
already ensured that the maximum exponent has a reasonable value for BigInts.

Updates the tests to ensure new limits are correctly applied.

[1] https://github.com/tc39/proposal-intl-numberformat-v3/pull/128

Comment 2

[André Bargull [:anba]]

Attachment: Bug 1795756 - Part 2: Remove DecimalNumber. r=dminor!

DecimalNumber is no longer needed after part 1, so we can remove it from
the source tree.

Depends on D179942

Comment 3

[André Bargull [:anba]]

Attachment: Bug 1795756 - Part 3: Update GetStringOrBooleanOption and useGrouping. r=dminor!

Update useGrouping option parsing to allow the strings "true" and "false",
but reject any other strings.

Depends on D179943

Comment 4

[André Bargull [:anba]]

Attachment: Bug 1795756 - Part 4: Update SetNumberFormatDigitOptions. r=dminor!

Updates SetNumberFormatDigitOptions per [1] and [2]. The next two parts will
update Intl.PluralRules to process the new roundingMode, roundingIncrement,
and trailingZeroDisplay options.

[1] https://github.com/tc39/proposal-intl-numberformat-v3/pull/102
[2] https://github.com/tc39/proposal-intl-numberformat-v3/pull/130

Depends on D179944

Comment 5

[André Bargull [:anba]]

Attachment: Bug 1795756 - Part 5: Support roundingMode, roundingIncrement, and stripTrailingZero for PluralRules. r=#platform-i18n-reviewers!

Required updates for the next patch in this stack.

Also replaces PluralRulesOptions::RoundingPriority with an alias to
NumberFormatOptions::RoundingPriority, so we don't have to duplicate the
RoundingPriority and RoundingMode enums.

Depends on D179945

Comment 6

[André Bargull [:anba]]

Attachment: Bug 1795756 - Part 6: Support roundingMode, roundingIncrement, and trailingZeroDisplay for Intl.PluralRules. r=dminor!

Second part to implement the changes from [1].

[1] https://github.com/tc39/proposal-intl-numberformat-v3/pull/130

Depends on D179946

Comment 7

[André Bargull [:anba]]

Attachment: Bug 1795756 - Part 7: Ship Intl.NumberFormat v3. r=dminor!

Removes the NIGHTLY_BUILD guards around Intl.NumberFormat v3 changes. The next
patches will perform further clean-ups.

Depends on D179948

Comment 8

[André Bargull [:anba]]

Attachment: Bug 1795756 - Part 8: Resolved no longer valid to-do note. r=dminor!

This to-do note is no longer necessary, because the issue has been fixed at
some point in the spec.

Depends on D179949

Comment 9

[André Bargull [:anba]]

Attachment: Bug 1795756 - Part 9: Sync spec steps and comments for Intl.NumberFormat. r=dminor!

Sync the implementation of Intl.NumberFormat with the current spec.

Depends on D179950

Comment 10

[André Bargull [:anba]]

Attachment: Bug 1795756 - Part 10: Sync spec steps and comments for Intl.PluralRules. r=dminor!

Sync the implementation of Intl.PluralRules with the current spec text.

Depends on D179951

Comment 11

[André Bargull [:anba]]

Attachment: Bug 1795756 - Part 11: Remove release-or-beta check from NumberFormat v3 tests. r=dminor!

Part 7 enabled NumberFormat v3 by default, so we no longer have to check
release_or_beta for the tests.

Depends on D179952

Comment 12

[André Bargull [:anba]]

Attachment: Bug 1795756 - Part 12: Remove release-or-beta check for test262 Intl.NumberFormat v3 tests. r=dminor!

Also remove the release_or_beta from the test262 tests.

Depends on D179953

Comment 13

[Dan Minor [:dminor]]

Anba is handling this one :)

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8535279b218b
Part 1: Update ToIntlMathematicalValue to apply exponent limits. r=dminor
https://hg.mozilla.org/integration/autoland/rev/162c97d8ff6d
Part 2: Remove DecimalNumber. r=dminor
https://hg.mozilla.org/integration/autoland/rev/c8a92856eb65
Part 3: Update GetStringOrBooleanOption and useGrouping. r=dminor
https://hg.mozilla.org/integration/autoland/rev/dd7ba758f201
Part 4: Update SetNumberFormatDigitOptions. r=dminor
https://hg.mozilla.org/integration/autoland/rev/487936c8e30f
Part 5: Support roundingMode, roundingIncrement, and stripTrailingZero for PluralRules. r=platform-i18n-reviewers,dminor
https://hg.mozilla.org/integration/autoland/rev/cc76bb24ee42
Part 6: Support roundingMode, roundingIncrement, and trailingZeroDisplay for Intl.PluralRules. r=dminor
https://hg.mozilla.org/integration/autoland/rev/9f247edc6c08
Part 7: Ship Intl.NumberFormat v3. r=dminor
https://hg.mozilla.org/integration/autoland/rev/18e70bddf7f3
Part 8: Resolved no longer valid to-do note. r=dminor
https://hg.mozilla.org/integration/autoland/rev/2fdf668a9aa4
Part 9: Sync spec steps and comments for Intl.NumberFormat. r=dminor
https://hg.mozilla.org/integration/autoland/rev/62d93979c1b0
Part 10: Sync spec steps and comments for Intl.PluralRules. r=dminor
https://hg.mozilla.org/integration/autoland/rev/0a739a37e5f7
Part 11: Remove release-or-beta check from NumberFormat v3 tests. r=dminor
https://hg.mozilla.org/integration/autoland/rev/24bc1e52a267
Part 12: Remove release-or-beta check for test262 Intl.NumberFormat v3 tests. r=dminor

Comment 15

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/8535279b218b
https://hg.mozilla.org/mozilla-central/rev/162c97d8ff6d
https://hg.mozilla.org/mozilla-central/rev/c8a92856eb65
https://hg.mozilla.org/mozilla-central/rev/dd7ba758f201
https://hg.mozilla.org/mozilla-central/rev/487936c8e30f
https://hg.mozilla.org/mozilla-central/rev/cc76bb24ee42
https://hg.mozilla.org/mozilla-central/rev/9f247edc6c08
https://hg.mozilla.org/mozilla-central/rev/18e70bddf7f3
https://hg.mozilla.org/mozilla-central/rev/2fdf668a9aa4
https://hg.mozilla.org/mozilla-central/rev/62d93979c1b0
https://hg.mozilla.org/mozilla-central/rev/0a739a37e5f7
https://hg.mozilla.org/mozilla-central/rev/24bc1e52a267

Comment 16

[Hamish Willee]

FF116 MDN docs work for this can be tracked in https://github.com/mdn/content/issues/27746 (in review). This was mostly BCD updates, and updates to include the new changes to PluralRules constructor options that other browsers do not appear to have implemented yet.