1811793 - Findbar status is invalid if activated too quickly

Status: NEW

(Toolkit :: Find Toolbar, defect)

Description

[Shane Hughes [:aminomancer]]

STR

1. Go to a page with some text
2. Open findbar and enter any small string that appears multiple times on the page. Ideally the string should appear around 5 times on the page.
3. Hold down the Enter key and observe that the status disappears occasionally (that is due to bug 1796078 handling the invalid status from the finder)
4. Randomly stop holding Enter. Repeat this until you happen to stop holding Enter when the status disappears, such that the status remains empty indefinitely (until find is activated again)

Expected

The status is always correct

Actual

The status is empty and stays that way until find is activated again.

Idk what exactly is the root cause, but the visual issue is due to the finder falsely reporting 0 matches - it's just that there isn't a better way of visually handling that case, because that's the same number we should expect when there are actually 0 matches. There's no way to differentiate those cases.

So aside from fixing the underlying issue that causes the finder to report 0 matches, one thing that could be done is to limit the rate of finds. In other words, the findbar's main functions (find forward/backward) should be throttled or debounced or something. Users shouldn't be able to trigger find so rapidly that the finder repeatedly gives them false results. So I'm thinking an easy solution is just a simple timer.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:enndeakin, could you have a look please?

For more information, please visit auto_nag documentation.

Comment 2

[tgn-ff]

I came to report the same issue, however I get a much older regression range: https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=9596d7f4a7457bccc78cadf9c39bcc9c4b5b97f8&tochange=b3ecb5aef45a8fb74764bb32e54567d57ed00383

On my end, this only (?) happens when I have the "Highlight All" enabled. When searching CJK texts you don't have to be particularly fast to trigger the issue.

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1796078

:eemeli, since you are the author of the regressor, bug 1796078, could you take a look?

For more information, please visit BugBot documentation.

Comment 4

[Alice0775 White]

Based on the regression window in comment #2, it is assumed that the root cause is bug 1553384.