Closed
Bug 1796209
Opened 2 years ago
Closed 1 year ago
CustomTabsToolbarFeature does not correct tint icons/text when no toolbar colour config provided
Categories
(Fenix :: Tabs, defect)
Tracking
(firefox124 fixed)
RESOLVED
FIXED
124 Branch
Tracking | Status | |
---|---|---|
firefox124 | --- | fixed |
People
(Reporter: gl, Assigned: towhite)
References
(Blocks 1 open bug)
Details
(Whiteboard: [fxdroid])
Attachments
(1 file)
From github: https://github.com/mozilla-mobile/android-components/issues/12155.
Steps to reproduce
- Send a CustomTabIntent without any colour customizations.
- Observe the back/three-dot icons.
Expected Behaviour
They should be tinted to the default toolbar colour that we have.
Actual Behaviour
Focus Fenix ┆Issue is synchronized with this Jira Task
Change performed by the Move to Bugzilla add-on.
Reporter | ||
Comment 1•2 years ago
|
||
This is probably related to https://bugzilla.mozilla.org/show_bug.cgi?id=1796210
Comment 2•2 years ago
|
||
The severity field is not set for this bug.
:cpeterson, could you have a look please?
For more information, please visit auto_nag documentation.
Flags: needinfo?(cpeterson)
Updated•2 years ago
|
Severity: -- → S3
Updated•2 years ago
|
Blocks: custom-tabs-refresh
Updated•2 years ago
|
Flags: needinfo?(cpeterson)
Updated•1 year ago
|
Comment 3•1 year ago
|
||
Comment 5•1 year ago
|
||
Authored by https://github.com/t-p-white
https://github.com/mozilla-mobile/firefox-android/commit/494bd98c4e7161bd1be82b98698dda360e4db0a7
[main] Bug 1796209 - If config.toolbarColor
is null use the toolbar
'menu' colour as a fallback
Status: NEW → RESOLVED
Closed: 1 year ago
status-firefox124:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 124 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•