Closed Bug 1796209 Opened 2 years ago Closed 1 year ago

CustomTabsToolbarFeature does not correct tint icons/text when no toolbar colour config provided

Categories

(Fenix :: Tabs, defect)

All
Android
defect

Tracking

(firefox124 fixed)

RESOLVED FIXED
124 Branch
Tracking Status
firefox124 --- fixed

People

(Reporter: gl, Assigned: towhite)

References

(Blocks 1 open bug)

Details

(Whiteboard: [fxdroid])

Attachments

(1 file)

From github: https://github.com/mozilla-mobile/android-components/issues/12155.

Steps to reproduce

  1. Send a CustomTabIntent without any colour customizations.
  2. Observe the back/three-dot icons.

Expected Behaviour

They should be tinted to the default toolbar colour that we have.

Actual Behaviour

Focus Fenix

┆Issue is synchronized with this Jira Task

Change performed by the Move to Bugzilla add-on.

The severity field is not set for this bug.
:cpeterson, could you have a look please?

For more information, please visit auto_nag documentation.

Flags: needinfo?(cpeterson)
Severity: -- → S3
Flags: needinfo?(cpeterson)
Whiteboard: [fxdroid]
Assignee: nobody → towhite
See Also: → 1832997
Duplicate of this bug: 1832997

Authored by https://github.com/t-p-white
https://github.com/mozilla-mobile/firefox-android/commit/494bd98c4e7161bd1be82b98698dda360e4db0a7
[main] Bug 1796209 - If config.toolbarColor is null use the toolbar 'menu' colour as a fallback

Status: NEW → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → 124 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: