1796238 - Hide lone progress bar step in aboutwelcome in HCM

Status: RESOLVED FIXED

(Firefox :: Messaging System, defect, P2)

Description

[Shane Hughes [:aminomancer]]

Bug 1790660 changed the progress bar appearance for HCM to make the contrast ratio sufficient, but this necessitated adding a border to the steps' parent element. This means CSS is not aware of how many steps there are, except by the aria-valuemax property.

We normally hide the progress bar when there is only one step, but the styles that accomplish that will not work in HCM anymore since they only hide the step itself, not the parent element. Hiding the parent element when it has only one step is impossible without using the ARIA attributes for styling, which I think is generally avoided when possible.

Anyway, there are 2 possibilities here:

.progress-bar[aria-valuemax="1"][aria-valuemin="1"] {
  opacity: 0;
}

Or we can modify this check to hideStepsIndicator || total <= 1 to simply not render the progress bar when there is only one step.

Comment 1

[Shane Hughes [:aminomancer]]

This will also be necessary in non-HCM mode after bug 1794702, since it removes the gray background for upcoming steps and puts a gray background on the progress bar itself.

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:tspurway, could you have a look please?

For more information, please visit auto_nag documentation.

Comment 3

[Russell Chan]

Attachment: Bug 1796238 - Hide lone progress bar step in aboutwelcome in HCM

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/611d8c6d5ce8
Hide lone progress bar step in aboutwelcome in HCM r=omc-reviewers,aminomancer

Comment 5

[Sandor Molnar[:smolnar]]

Backed out for causing bc failures in browser/components/newtab/test/browser/browser_aboutwelcome_multistage_primary.js

Backout link: https://hg.mozilla.org/integration/autoland/rev/a54d8b8345d6e7a9067000cb758d751d1ea85938

Push with failures

Failure log: TEST-UNEXPECTED-FAIL | browser/components/newtab/test/browser/browser_aboutwelcome_multistage_primary.js | Uncaught exception in test - undefined - timed out after 50 tries.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/105be1098e10
Hide lone progress bar step in aboutwelcome in HCM r=omc-reviewers,aminomancer

Comment 7

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/105be1098e10