1796348 - A-C Target Android 13 (SDK 33)

Status: RESOLVED FIXED

(Firefox for Android :: General, task, P1)

Description

[Gabriel Luong [:gl] (ΦωΦ)]

From github: https://github.com/mozilla-mobile/android-components/issues/12944.

The latest SDK apps can target is 33: https://developer.android.com/about/versions/13

See also related Android 13 issues

Currently blocked on https://github.com/mozilla-mobile/android-components/issues/12378.

┆Issue is synchronized with this Jira Task

Change performed by the Move to Bugzilla add-on.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:cpeterson, could you have a look please?

For more information, please visit auto_nag documentation.

Comment 2

[BMO Automation]

Attachment: [mozilla-mobile/firefox-android] Bug 1796348: Target Android 13 (SDK 33) (#219)

Comment 3

[BMO Automation]

Attachment: [mozilla-mobile/firefox-android] Bug 1796348: Add extra granular media permissions for devices with Android 13 and above. (#231)

Comment 4

[BMO Automation]

Comment on attachment 9305780 [details] [review]
[mozilla-mobile/firefox-android] Bug 1796348: Add extra granular media permissions for devices with Android 13 and above. (#231)

GitHub pull request attachment was moved to bug 1802579. Setting attachment 9305780 [details] [review] to obsolete.

Comment 5

[Mihai Adrian Carare [:mcarare]]

This will be done after Fenix and Focus target SDK 33.
The only change related to this upgrade that will land before is the change that allows requesting granular media permissions on devices with Android 13 and later.

Comment 6

[Kaya [:kaya]]

Mihai can you please migrate, if exists, the blocking Fenix ticket to Bugzilla?

Comment 7

[BMO Automation]

Attachment: [mozilla-mobile/firefox-android] Bug 1796348 - Add post notification permission requirement for downloads. (#604)

Comment 8

[BMO Automation]

Attachment: [mozilla-mobile/firefox-android] Revert "Bug 1796348 - Add post notification permission requirement for downloads." (#629)

Comment 9

[BMO Automation]

Attachment: [mozilla-mobile/firefox-android] Bug 1796348 - Handle requesting notification permission for web notifications. (#691)

Comment 10

[BMO Automation]

Attachment: [mozilla-mobile/firefox-android] Bug 1796348 - Upgrade core to 1.9.0 (#731)

Comment 11

[BMO Automation]

Attachment: [mozilla-mobile/firefox-android] Bug 1796348, Bug 1811795 - Target Android 13 in Fenix and AC (#849)

Comment 12

[Joe M [:jmahon]]

I had previously believed that updating to target SDK 13 would result in users on Android 12 and below receiving the notification permission prompt (which wouldn't be ideal), but that I was mistaken about that. In light of that, this change doesn't need to be blocked by the permissions audit in bug 1818422; that can be an independent initiative.

Comment 13

[BMO Github Automation]

Authored by https://github.com/mcarare
https://github.com/mozilla-mobile/firefox-android/commit/d63edcdac72bf3677050cee81676dd15f0e1c0fe
[main] Bug 1796348 - Target Android 13 in AC.

Authored by https://github.com/mcarare
https://github.com/mozilla-mobile/firefox-android/commit/c4deaca69f73d54eab944690a1d247fba3159473
[main] Bug 1796348 -  Upgrade core to 1.9.0

Authored by https://github.com/mcarare
https://github.com/mozilla-mobile/firefox-android/commit/ed776b1fcd76afc4ca30445dd81a9fb2d4f53103
[main] Bug 1796348 - Add manifest notification permission for modules that use notifications.

Authored by https://github.com/mcarare
https://github.com/mozilla-mobile/firefox-android/commit/92d368bfcf4d5b16015f5c22187d1036784ee791
[main] Bug 1796348 - Implement a notification delegate.

Authored by https://github.com/mcarare
https://github.com/mozilla-mobile/firefox-android/commit/148e3d175233f30c8cff3ad5acc417cd1752de11
[main] Bug 1796348 - Implement a lint check to avoid calling notify directly.

Authored by https://github.com/mcarare
https://github.com/mozilla-mobile/firefox-android/commit/f4abec86bbdb59af3014b98a79c71b5742a1de43
[main] Bug 1796348 - Add notification delegate as a component in apps.

Authored by https://github.com/mcarare
https://github.com/mozilla-mobile/firefox-android/commit/105ec4f08a9267712ddb08f90f74a25ed71afe20
[main] Bug 1796348 - Bind notification delegate to app activities.

Authored by https://github.com/mcarare
https://github.com/mozilla-mobile/firefox-android/commit/8387cb01662740baa3a19760050b9f3750fdc4d1
[main] Bug 1796348 - Add a notification delegate to download manager.

Authored by https://github.com/mcarare
https://github.com/mozilla-mobile/firefox-android/commit/07acd334403b415299c39dce693b79dfddfa9034
[main] Bug 1796348 - Add a notification delegate to addon updater.

Authored by https://github.com/mcarare
https://github.com/mozilla-mobile/firefox-android/commit/b62a01f235ee6568cf8161e73178821120d731cf
[main] Bug 1796348 - Add a notification delegate to  web notifications feature.

Authored by https://github.com/mcarare
https://github.com/mozilla-mobile/firefox-android/commit/3d0f44294e770679014990f5ea946865aa61c810
[main] Bug 1796348 - Add a notification delegate to RecordingDevicesMiddleware.

Authored by https://github.com/mcarare
https://github.com/mozilla-mobile/firefox-android/commit/1bd9d73bab8655df8276f4041204e3a49755bfe8
[main] Bug 1796348 - Add a notification delegate to WebAppSiteControlsFeature.

Authored by https://github.com/mcarare
https://github.com/mozilla-mobile/firefox-android/commit/55b9b62c1c73c464bec14286e41e1bb9894f8710
[main] Bug 1796348 - Add a notification delegate to MediaSessionService.

Authored by https://github.com/mcarare
https://github.com/mozilla-mobile/firefox-android/commit/a377e06626b25a91fd83f79d56357b0cca9ec061
[main] Bug 1796348 - Add a notification delegate to AbstractFetchDownloadService.

Authored by https://github.com/mcarare
https://github.com/mozilla-mobile/firefox-android/commit/cfcce28a6345e95784f1c7106fa6e303920bcfce
[main] Bug 1796348 - Add a notification delegate to AbstractPrivateNotificationService.

Authored by https://github.com/mcarare
https://github.com/mozilla-mobile/firefox-android/commit/9d50a6e50c25e3e5b00da09e4fdc74c69e624d26
[main] Bug 1796348 - Add a notification delegate to CrashReporter.

Authored by https://github.com/mcarare
https://github.com/mozilla-mobile/firefox-android/commit/d840610ec1f4d1146b4442f60b619472062ec7a8
[main] Bug 1796348 - Use a notification delegate for PoweredByNotification.

Authored by https://github.com/mcarare
https://github.com/mozilla-mobile/firefox-android/commit/309f4e40322177fd1ea143f23bfb071813c81004
[main] Bug 1796348 - Remove unused notify extension methods in SharedIdsHelper.

Comment 14

[Mihai Adrian Carare [:mcarare]]

Opened https://mozilla-hub.atlassian.net/browse/QA-1840 QA PI request to test this change in depth, similar to the already performed testing for Focus at the moment it started targetting Android 13.

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e18e29367db1
Add post notification permission requirement for downloads.
https://hg.mozilla.org/integration/autoland/rev/e79dea0a8e12
Correctly identify active download when receiving permissions.
https://hg.mozilla.org/integration/autoland/rev/ec7871f9cc8e
Revert "Bug 1796348 - Add post notification permission requirement for downloads."
https://hg.mozilla.org/integration/autoland/rev/449f6642a506
Target Android 13 in AC.
https://hg.mozilla.org/integration/autoland/rev/75efddbed643
Upgrade core to 1.9.0
https://hg.mozilla.org/integration/autoland/rev/403f220af240
Add manifest notification permission for modules that use notifications.
https://hg.mozilla.org/integration/autoland/rev/74e2d563ff96
Implement a notification delegate.
https://hg.mozilla.org/integration/autoland/rev/6b9d630d4115
Implement a lint check to avoid calling notify directly.
https://hg.mozilla.org/integration/autoland/rev/8ad3c59a789e
Add notification delegate as a component in apps.
https://hg.mozilla.org/integration/autoland/rev/fcebd5315362
Bind notification delegate to app activities.
https://hg.mozilla.org/integration/autoland/rev/2bc0682fd97e
Add a notification delegate to download manager.
https://hg.mozilla.org/integration/autoland/rev/b1f6602b9256
Add a notification delegate to addon updater.
https://hg.mozilla.org/integration/autoland/rev/01d174c00e09
Add a notification delegate to  web notifications feature.
https://hg.mozilla.org/integration/autoland/rev/abacf1249d89
Add a notification delegate to RecordingDevicesMiddleware.
https://hg.mozilla.org/integration/autoland/rev/70f2bade9202
Add a notification delegate to WebAppSiteControlsFeature.
https://hg.mozilla.org/integration/autoland/rev/85247f202199
Add a notification delegate to MediaSessionService.
https://hg.mozilla.org/integration/autoland/rev/422f92d491fd
Add a notification delegate to AbstractFetchDownloadService.
https://hg.mozilla.org/integration/autoland/rev/6b41a5c681b0
Add a notification delegate to AbstractPrivateNotificationService.
https://hg.mozilla.org/integration/autoland/rev/d9eab1caba77
Add a notification delegate to CrashReporter.
https://hg.mozilla.org/integration/autoland/rev/748f16613e15
Use a notification delegate for PoweredByNotification.
https://hg.mozilla.org/integration/autoland/rev/d4642aa7ca63
Remove unused notify extension methods in SharedIdsHelper.