1826933 - Avoid memory leaks in NotificationsDelegate

Status: RESOLVED WONTFIX

(Fenix :: General, enhancement, P3)

Description

[Mihai Adrian Carare [:mcarare]]

As a follow-up to https://bugzilla.mozilla.org/show_bug.cgi?id=1796348, we should investigate the implications of keeping references to activities in a 'NotificationsDelegate'.

Comment 1

[BMO Github Automation]

Attachment: [mozilla-mobile/firefox-android] Bug 1826933 - Avoid memory leaks in NotificationsDelegate (#1586)

Comment 2

[BMO Github Automation]

Authored by https://github.com/mcarare
https://github.com/mozilla-mobile/firefox-android/commit/f757185c84882b06a846daf82f103b5d26de449e
[main] Bug 1826933 - Use WeakHashMap and WeakReference for activity and launcher.

Authored by https://github.com/mcarare
https://github.com/mozilla-mobile/firefox-android/commit/029bc686b1b45477dfb15ce29b64c2d5df1cd3a1
[main] Bug 1826933 - Add tests for NotificationsDelegate.

Comment 3

[Lorand Janos]

Verified on the latest Nightly 117.0a1 (2023-07-21).
I didn't find any issue regarding notifications. Compared the latest Nightly build with the latest Beta and Chrome browsers.
Device used: Oppo Find X5 (Android 13).
Marking the ticket as verified.

Comment 4

[BMO Github Automation]

Authored by https://github.com/mcarare
https://github.com/mozilla-mobile/firefox-android/commit/2f90b72ce09ad2b56218ed555e312326ef9163c7
[main] Revert "Bug 1826933 - Add tests for NotificationsDelegate."

Authored by https://github.com/mcarare
https://github.com/mozilla-mobile/firefox-android/commit/9dac063f5d8538bdc32ff8fc3ccdd7a6281c42aa
[main] Revert "Bug 1826933 - Use WeakHashMap and WeakReference for activity and launcher."

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

Since nightly and release are affected, beta will likely be affected too.
For more information, please visit BugBot documentation.

Comment 6

[BMO Github Automation]

Authored by https://github.com/mcarare
https://github.com/mozilla-mobile/firefox-android/commit/a9c0a058b3f480d9f1a8a7fb267548f78d8d0c09
[releases_v118] Revert "Bug 1826933 - Add tests for NotificationsDelegate."

Authored by https://github.com/mcarare
https://github.com/mozilla-mobile/firefox-android/commit/6ffeb4b7a57267b7adbae96043f6fc118f0b65b7
[releases_v118] Revert "Bug 1826933 - Use WeakHashMap and WeakReference for activity and launcher."

Comment 7

[BMO Github Automation]

Authored by https://github.com/mcarare
https://github.com/mozilla-mobile/firefox-android/commit/ab6bcc65b2b612f6234b9cdf48613a7ac19ff1d5
[releases_v117] Revert "Bug 1826933 - Add tests for NotificationsDelegate."

Authored by https://github.com/mcarare
https://github.com/mozilla-mobile/firefox-android/commit/f86c9084d99bf23685a2fe582e346cb15751d883
[releases_v117] Revert "Bug 1826933 - Use WeakHashMap and WeakReference for activity and launcher."

Comment 8

[Mihai Adrian Carare [:mcarare]]

No memory leaks were reported, so this seems like an over engineering task.