Allow for notifying consumers on unsuccessful Save to PDF requests
Categories
(Fenix :: Browser Engine, enhancement, P2)
Tracking
(firefox108 fixed)
Tracking | Status | |
---|---|---|
firefox108 | --- | fixed |
People
(Reporter: cpeterson, Assigned: amejia)
References
Details
(Whiteboard: [geckoview:m108])
Attachments
(4 files)
From github: https://github.com/mozilla-mobile/android-components/issues/12642.
In at least two cases in in the
GeckEngine.requestPdfToDownload
, we can unsuccessfully return a PDF. Our current error handling in https://github.com/mozilla-mobile/android-components/pull/12277 is to silently fail, but this might not be helpful to users if they are expecting to see a PDF.We should come up with a solution, possibly similar to the Download State one, for handling the error cases so that we can notify consumers.
cc: @Amejia481 , @ohall-m
┆Issue is synchronized with this Jira Task
Change performed by the Move to Bugzilla add-on.
Reporter | ||
Comment 1•1 year ago
|
||
Arturo, FYI: this bug was moved from A-C's GitHub issue tracker to Bugzilla. I'm assigning this A-C bug to you because the GitHub issue was assigned to you: https://github.com/mozilla-mobile/android-components/issues/12642
Do we need to fix this bug in the same Fenix version that ships Save as PDF? Is that version 107 or 108?
Assignee | ||
Comment 2•1 year ago
|
||
Arturo, FYI: this bug was moved from A-C's GitHub issue tracker to Bugzilla. I'm assigning this A-C bug to you because the GitHub issue was assigned to you: https://github.com/mozilla-mobile/android-components/issues/12642
Thanks no problem!
Do we need to fix this bug in the same Fenix version that ships Save as PDF? Is that version 107 or 108?
Yes, we need to ship the same version of AC and Fenix, but the PDF feature is still only in nightly behind a feature flag at the moment.
It was introduced in v107.0b1, in case we would like to uplift the feature to that version, we will need to uplift the AC parts and remove the feature flag.
Reporter | ||
Updated•1 year ago
|
Comment 3•1 year ago
|
||
Comment 4•1 year ago
|
||
Comment 5•1 year ago
|
||
Comment 6•1 year ago
|
||
Comment 7•1 year ago
|
||
Reporter | ||
Comment 8•1 year ago
|
||
We don't need to uplift this fix to Beta 107.
Description
•