1780639 - [meta] Let Save as PDF ride the trains

Status: VERIFIED FIXED

(GeckoView :: PDF Viewer, enhancement, P1)

Description

[Chris Peterson [:cpeterson]]

"Save as PDF" epic:

• https://mozilla-hub.atlassian.net/browse/FNXV2-19887

Depends on:

• AC support: https://mozilla-hub.atlassian.net/browse/FNXV2-20087
• Integrate Save to PDF into GeckoSession: https://mozilla-hub.atlassian.net/browse/FNXV2-20630
• Create UI for allowing users to save a session to PDF: https://mozilla-hub.atlassian.net/browse/FNXV2-20088

See also:

• Request to add PDF settings: bug 1770971

Comment 1

[Kevin Brosnan [Ex-Mozilla]]

Designs are at https://www.figma.com/file/4TFvx6UlVO127bubv1WZKZ/Print-to-PDF-%2F-Share-Sheet?node-id=319%3A22535

Comment 2

[Chris Peterson [:cpeterson]]

Arturo says we need to fix some UI issues, but he will land his WIP in Nightly 106 so we can get user testing.

Comment 3

[Chris Peterson [:cpeterson]]

Deferring Save as PDF to 107 because Arturo is busy with MR work in 106.

Comment 4

[Chris Peterson [:cpeterson]]

P1 because Arturo is working on this now.

Comment 5

[Arturo Mejia [:amejia]]

We landed the UI only in nightly with a feature flag yesterday bug #1784554 that will improve the usability, we will need to do some extra work to handle error reporting that will be covered on https://github.com/mozilla-mobile/android-components/issues/12642.

Comment 6

[Chris Peterson [:cpeterson]]

Targeting 108. We need to:

1. Fix https://github.com/mozilla-mobile/android-components/issues/12642
2. Flip the feature flag from nightly-only to ride the trains to Beta and Release.

Comment 7

[Chris Peterson [:cpeterson]]

Arturo is fixing error handling bug 1796482, but we can ship Save as PDF without it. Remove the feature flag in this bug.

Comment 8

[Arturo Mejia [:amejia]]

I file this PR on Fenix for this ticket https://github.com/mozilla-mobile/fenix/pull/27573

Comment 9

[Chris Peterson [:cpeterson]]

Fixed in 108: https://github.com/mozilla-mobile/fenix/commit/3fe88c05b2d69fad1614dc713a90fb9641ef702a

Comment 10

[Chris Peterson [:cpeterson]]

Release Note Request (optional, but appreciated)
[Why is this notable]: Save as PDF is a popular Fenix user request.
[Affects Firefox for Android]: Yes. This feature only affects Fenix, not iOS or desktop.
[Suggested wording]: You can now save web pages as PDF files to conveniently access them later from your Downloads folder.
[Links (documentation, blog post, etc)]: SUMO article: https://support.mozilla.org/kb/save-web-pages-pdf-firefox-android . That will be the article's URL, but the page is current a placeholder because the article is still being written.

Comment 11

[Fabi]

SUMO link for Save web pages as PDF in Firefox for Android

https://support.mozilla.org/en-US/kb/save-web-pages-pdf-firefox-android