1796746 - Storage tree is not visible if devtools is narrow

Status: VERIFIED FIXED

(DevTools :: Storage Inspector, defect)

Description

[6k64x4ma]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:107.0) Gecko/20100101 Firefox/107.0

Steps to reproduce:

1. Open the Storage Inspector on any page.
2. Dock the Developer Tools to right or make the window narrower.

Actual results:

The storage tree is not visible above the table.

Expected results:

The storage tree should be visible.

Comment 1

[BugBot [:suhaib / :marco]]

:emilio, since you are the author of the regressor, bug 1792473, could you take a look? Also, could you set the severity field?

For more information, please visit auto_nag documentation.

Comment 3

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1796746 - Fix storage / stylesheet split views with modern flexbox. r=jdescottes

contain: size makes the automatic min size be zero, which is too
aggressive when the component is in responsive mode (and we rely on the
its auto height rather than flexing for it to be visible).

So we need to use min-{width,height}: 0 in this case. While at it
improve the behavior of splitters when switching from / to responsive
mode (we'd keep heights / widths from the splitters in effect).

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/13c9b70ebb14
Fix storage / stylesheet split views with modern flexbox. r=jdescottes

Comment 5

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/13c9b70ebb14

Comment 6

[BugBot [:suhaib / :marco]]

Set release status flags based on info from the regressing bug 1792473

Comment 7

[BugBot [:suhaib / :marco]]

The patch landed in nightly and beta is affected.
:emilio, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox107 to wontfix.

For more information, please visit auto_nag documentation.

Comment 8

[Emilio Cobos Álvarez [:emilio]]

Comment on attachment 9299641 [details]
Bug 1796746 - Fix storage / stylesheet split views with modern flexbox. r=jdescottes

Beta/Release Uplift Approval Request

• User impact if declined: comment 0
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: comment 0
• List of other uplifts needed: none
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Relatively scoped CSS changes to improve layout on small devtools windows.
• String changes made/needed: none
• Is Android affected?: No

Comment 9

[Donal Meehan [:dmeehan]]

Comment on attachment 9299641 [details]
Bug 1796746 - Fix storage / stylesheet split views with modern flexbox. r=jdescottes

Approved for 107.0b5.

Comment 10

[Donal Meehan [:dmeehan]]

https://hg.mozilla.org/releases/mozilla-beta/rev/a2a5289aceec

Comment 11

[Timea Zsoldos [:tzsoldos], Desktop QA]

I have reproduced this issue using Firefox 108.0a1 (2022.10.21) on Win 10 x64.
I can confirm this issue is fixed, I verified using Firefox 107.0b5 on Win 10 x64, macOS 12 and Ubuntu 22 x64.