1797024 - Make frontend::WellKnownParserAtoms globally accessible singleton

Status: RESOLVED FIXED

(Core :: JavaScript Engine, task, P1)

Description

[Tooru Fujisawa [:arai]]

Similar to bug 1786834, parser has dependency to JSRuntime to retrieve frontend::WellKnownParserAtoms.

frontend::WellKnownParserAtoms is singleton held by top-level JSRuntime, and we can make it globally accessible singleton, independent from JSRuntime

Comment 1

[Tooru Fujisawa [:arai]]

Attachment: Bug 1797024 - Part 1: Move OOM handling out of frontend::WellKnownParserAtoms. r?nbp!

Depends on D160205

Comment 2

[Tooru Fujisawa [:arai]]

Attachment: Bug 1797024 - Part 2: Move WellKnownParserAtoms out of JSRuntime. r?nbp!

Depends on D160206

Comment 3

[Tooru Fujisawa [:arai]]

Attachment: Bug 1797024 - Part 3: Remove unnecessary JSContext parameters. r?nbp!

Depends on D160207

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/149d939edcea
Part 1: Move OOM handling out of frontend::WellKnownParserAtoms. r=nbp
https://hg.mozilla.org/integration/autoland/rev/c4fcaed9709c
Part 2: Move WellKnownParserAtoms out of JSRuntime. r=nbp
https://hg.mozilla.org/integration/autoland/rev/ea88488b0626
Part 3: Remove unnecessary JSContext parameters. r=nbp

Comment 5

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c957d94a13a0
Backed out 5 changesets (bug 1797024, bug 1786834) for causing build bustages on ParserAtom.cpp. CLOSED TREE

Comment 6

[Serban Stanca [:SerbanS]]

Backed out for causing build bustages on ParserAtom.cpp.

• Backout link
• Push with failures
• Failure Log
• Failure line: /builds/worker/checkouts/gecko/js/src/frontend/ParserAtom.cpp:1316:3: error: use of undeclared identifier 'initialized_'

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/18f609b05b50
Part 1: Move OOM handling out of frontend::WellKnownParserAtoms. r=nbp
https://hg.mozilla.org/integration/autoland/rev/ad0ab9e860d0
Part 2: Move WellKnownParserAtoms out of JSRuntime. r=nbp
https://hg.mozilla.org/integration/autoland/rev/a3ef21e74788
Part 3: Remove unnecessary JSContext parameters. r=nbp

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bd401d7456e0
Part 1: Move OOM handling out of frontend::WellKnownParserAtoms. r=nbp
https://hg.mozilla.org/integration/autoland/rev/8967cf32fb68
Part 2: Move WellKnownParserAtoms out of JSRuntime. r=nbp
https://hg.mozilla.org/integration/autoland/rev/0db2c5e40d05
Part 3: Remove unnecessary JSContext parameters. r=nbp

Comment 9

[Cristian Tuns]

Backed out for causing spidermonkey bustages.

• Backout link
• Push with failures
• Failure Log
• Failure line: /builds/worker/checkouts/gecko/js/src/vm/SharedImmutableStringsCache.cpp:127:8: error: incomplete type 'JSRuntime' named in nested name specifier

And also this: https://treeherder.mozilla.org/logviewer?job_id=397546713&repo=autoland

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b9988011c8e5
Part 1: Move OOM handling out of frontend::WellKnownParserAtoms. r=nbp
https://hg.mozilla.org/integration/autoland/rev/221b3e1df1e3
Part 2: Move WellKnownParserAtoms out of JSRuntime. r=nbp
https://hg.mozilla.org/integration/autoland/rev/6137c80af88e
Part 3: Remove unnecessary JSContext parameters. r=nbp

Comment 11

[Cristian Tuns]

Backed out for causing one of the issues above(https://bugzilla.mozilla.org/show_bug.cgi?id=1797024#c9)

• Backout link
• Push with failures
• Failure Log
• Failure line: ==2796==ERROR: AddressSanitizer: attempting to call malloc_usable_size() for pointer which is not owned: 0x7fa17fae9520
  SUMMARY: AddressSanitizer: bad-malloc_usable_size /builds/worker/fetches/llvm-project/compiler-rt/lib/asan/asan_malloc_linux.cpp:119:3 in malloc_usable_size

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/86bbdbf5f8e6
Part 1: Move OOM handling out of frontend::WellKnownParserAtoms. r=nbp
https://hg.mozilla.org/integration/autoland/rev/b5aebe1131f5
Part 2: Move WellKnownParserAtoms out of JSRuntime. r=nbp
https://hg.mozilla.org/integration/autoland/rev/2b4c6d1a1b8b
Part 3: Remove unnecessary JSContext parameters. r=nbp

Comment 13

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/86bbdbf5f8e6
https://hg.mozilla.org/mozilla-central/rev/b5aebe1131f5
https://hg.mozilla.org/mozilla-central/rev/2b4c6d1a1b8b