Closed Bug 1797024 Opened 3 years ago Closed 3 years ago

Make frontend::WellKnownParserAtoms globally accessible singleton

Categories

(Core :: JavaScript Engine, task, P1)

Product:
Core
Component:
JavaScript Engine
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
109 Branch
Tracking Flags:
Tracking Status
firefox109 --- fixed

People

(Reporter: arai, Assigned: arai)

References

Details

Attachments

(3 files)

Bug 1797024 - Part 1: Move OOM handling out of frontend::WellKnownParserAtoms. r?nbp!
48 bytes, text/x-phabricator-request
Details | Review
Bug 1797024 - Part 2: Move WellKnownParserAtoms out of JSRuntime. r?nbp!
48 bytes, text/x-phabricator-request
Details | Review
Bug 1797024 - Part 3: Remove unnecessary JSContext parameters. r?nbp!
48 bytes, text/x-phabricator-request
Details | Review

Similar to bug 1786834, parser has dependency to JSRuntime to retrieve frontend::WellKnownParserAtoms.

frontend::WellKnownParserAtoms is singleton held by top-level JSRuntime, and we can make it globally accessible singleton, independent from JSRuntime

Assignee: nobody → arai.unmht
Status: NEW → ASSIGNED
Severity: -- → N/A
Priority: -- → P1
Pushed by arai_a@mac.com: https://hg.mozilla.org/integration/autoland/rev/149d939edcea Part 1: Move OOM handling out of frontend::WellKnownParserAtoms. r=nbp https://hg.mozilla.org/integration/autoland/rev/c4fcaed9709c Part 2: Move WellKnownParserAtoms out of JSRuntime. r=nbp https://hg.mozilla.org/integration/autoland/rev/ea88488b0626 Part 3: Remove unnecessary JSContext parameters. r=nbp
Backout by sstanca@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/c957d94a13a0 Backed out 5 changesets (bug 1797024, bug 1786834) for causing build bustages on ParserAtom.cpp. CLOSED TREE

Backed out for causing build bustages on ParserAtom.cpp.

Flags: needinfo?(arai.unmht)
Pushed by arai_a@mac.com: https://hg.mozilla.org/integration/autoland/rev/18f609b05b50 Part 1: Move OOM handling out of frontend::WellKnownParserAtoms. r=nbp https://hg.mozilla.org/integration/autoland/rev/ad0ab9e860d0 Part 2: Move WellKnownParserAtoms out of JSRuntime. r=nbp https://hg.mozilla.org/integration/autoland/rev/a3ef21e74788 Part 3: Remove unnecessary JSContext parameters. r=nbp
Flags: needinfo?(arai.unmht)
Pushed by arai_a@mac.com: https://hg.mozilla.org/integration/autoland/rev/bd401d7456e0 Part 1: Move OOM handling out of frontend::WellKnownParserAtoms. r=nbp https://hg.mozilla.org/integration/autoland/rev/8967cf32fb68 Part 2: Move WellKnownParserAtoms out of JSRuntime. r=nbp https://hg.mozilla.org/integration/autoland/rev/0db2c5e40d05 Part 3: Remove unnecessary JSContext parameters. r=nbp

Backed out for causing spidermonkey bustages.

  • Backout link
  • Push with failures
  • Failure Log
  • Failure line: /builds/worker/checkouts/gecko/js/src/vm/SharedImmutableStringsCache.cpp:127:8: error: incomplete type 'JSRuntime' named in nested name specifier

And also this: https://treeherder.mozilla.org/logviewer?job_id=397546713&repo=autoland

Flags: needinfo?(arai.unmht)
Pushed by arai_a@mac.com: https://hg.mozilla.org/integration/autoland/rev/b9988011c8e5 Part 1: Move OOM handling out of frontend::WellKnownParserAtoms. r=nbp https://hg.mozilla.org/integration/autoland/rev/221b3e1df1e3 Part 2: Move WellKnownParserAtoms out of JSRuntime. r=nbp https://hg.mozilla.org/integration/autoland/rev/6137c80af88e Part 3: Remove unnecessary JSContext parameters. r=nbp
Flags: needinfo?(arai.unmht)

Backed out for causing one of the issues above(https://bugzilla.mozilla.org/show_bug.cgi?id=1797024#c9)

  • Backout link
  • Push with failures
  • Failure Log
  • Failure line: ==2796==ERROR: AddressSanitizer: attempting to call malloc_usable_size() for pointer which is not owned: 0x7fa17fae9520
    SUMMARY: AddressSanitizer: bad-malloc_usable_size /builds/worker/fetches/llvm-project/compiler-rt/lib/asan/asan_malloc_linux.cpp:119:3 in malloc_usable_size
Flags: needinfo?(arai.unmht)
Pushed by arai_a@mac.com: https://hg.mozilla.org/integration/autoland/rev/86bbdbf5f8e6 Part 1: Move OOM handling out of frontend::WellKnownParserAtoms. r=nbp https://hg.mozilla.org/integration/autoland/rev/b5aebe1131f5 Part 2: Move WellKnownParserAtoms out of JSRuntime. r=nbp https://hg.mozilla.org/integration/autoland/rev/2b4c6d1a1b8b Part 3: Remove unnecessary JSContext parameters. r=nbp

https://hg.mozilla.org/mozilla-central/rev/86bbdbf5f8e6
https://hg.mozilla.org/mozilla-central/rev/b5aebe1131f5
https://hg.mozilla.org/mozilla-central/rev/2b4c6d1a1b8b

Status: ASSIGNED → RESOLVED
Closed: 3 years ago
status-firefox109: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 109 Branch
Flags: needinfo?(arai.unmht)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: