1797093 - Update button is showing on MSIX about dialog

Status: RESOLVED FIXED

(Firefox :: Installer, defect)

Description

[Mike Kaply [:mkaply]]

The nightly MSIX is showing the Update button in the about dialog. It did not before.

The issue is that the updateDeck

https://searchfox.org/mozilla-central/rev/88f285c5163f73abd209d4f73cfa476660351982/browser/base/content/aboutDialog.xhtml#68

is getting a selectedIndex of 1 by default whereas before it getting no index so it was showing as blank (there is no updater in this case).

I believe this is fallout from the flexbox work.

Comment 1

[Mike Kaply [:mkaply]]

This is a guess on regression.

Comment 2

[[e-mail] (:bhearsum)]

Emilio, do you have any thoughts on this?

Comment 3

[Emilio Cobos Álvarez (:emilio)]

Please don't guess? Is there a way to bisect msix builds? selectedIndex on a deck is 0 by default. What used to be shown before that? Just nothing?

Comment 4

[Mike Kaply [:mkaply]]

Yes, before that it showed nothing and there was no attribute for selectedIndex set on the deck.

All children of the deck were hidden.

I'll backout flexbox on the about dialog and see what happens.

Comment 5

[Mike Kaply [:mkaply]]

Just looking at the patch, it definitely added a lot of selectedPanel stuff that wasn't there before, so I don't have much doubt this was the cause.

I guess the question is should we just add an empty panel to handle this case?

Comment 6

[Mike Kaply [:mkaply]]

Ah, it was a stack before which I guess can have no selected item.

Comment 7

[Mike Kaply [:mkaply]]

Yeah, this CSS was probably the thing:

#updateDeck > *:not(.selected) {
  visibility: hidden;
}

Comment 8

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1792337

Comment 9

[Mike Kaply [:mkaply]]

Attachment: Bug 1797093 - Explicitly show nothing when updater is disabled. r?emilio

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/91904cb92e98
Explicitly show nothing when updater is disabled. r=emilio,application-update-reviewers,bytesized

Comment 11

[Mike Kaply [:mkaply]]

We'll need to take the old version of this into the 107 beta once it's landed.

Comment 12

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/91904cb92e98

Comment 13

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:mkaply, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox107 to wontfix.

For more information, please visit auto_nag documentation.

Comment 14

[Mike Kaply [:mkaply]]

Attachment: Patch for beta

Approval Request Comment
[Feature/Bug causing the regression]: 1792337
[User impact if declined]: MSIX builds show an update button
[Is this code covered by automated tests?]: No
[Has the fix been verified in Nightly?]: No
[Needs manual test from QE? If yes, steps to reproduce]: Install MSIX, go to about dialog verify there is no update button.
[List of other uplifts needed for the feature/fix]: None
[Is the change risky?]: No
[Why is the change risky/not risky?]: Just adds code for this case.
[String changes made/needed]:

Comment 15

[Donal Meehan [:dmeehan]]

Comment on attachment 9300791 [details] [diff] [review]
Patch for beta

Approved for 107.0b7.

Comment 16

[Donal Meehan [:dmeehan]]

https://hg.mozilla.org/releases/mozilla-beta/rev/d8f332e37854

Comment 17

[Monica Chiorean]

I was able to reproduce the issue on Win11 using FF build from 24-10-2022.
Verified on latest Nightly build 108.0a1 (20221031095213) that no "check for updates" button is displayed on About dialog on neither Win10/Win11.

Hello Mike,
I can not verify the fix on Beta as I was not able to find the msix build for Beta.
Do you know if there is any location where I can find it? Thank you so much.

Comment 18

[[e-mail] (:bhearsum)]

(In reply to Monica Chiorean from comment #17)

I was able to reproduce the issue on Win11 using FF build from 24-10-2022.
Verified on latest Nightly build 108.0a1 (20221031095213) that no "check for updates" button is displayed on About dialog on neither Win10/Win11.

Hello Mike,
I can not verify the fix on Beta as I was not able to find the msix build for Beta.
Do you know if there is any location where I can find it? Thank you so much.

MSIX Betas are in directories like https://archive.mozilla.org/pub/firefox/releases/107.0b7/win64/multi/. (I don't know if this fix made it into Beta 7 though.)

Comment 19

[Monica Chiorean]

It made it to 107.0b7 as after install I did not get the "check for updates" on both Win10 and Win11. Marking issue as Verified.