./mach bootstrap installs wrong clang-tools binaries in aarch64 mac environment
Categories
(Firefox Build System :: Bootstrap Configuration, defect)
Tracking
(firefox108 fixed)
Tracking | Status | |
---|---|---|
firefox108 | --- | fixed |
People
(Reporter: saschanaz, Assigned: glandium)
References
Details
Attachments
(1 file)
Everything in .mozbuild/clang-tools/clang-tidy/bin/clang-format
throws bad CPU type in executable
, causing trouble using clangd and clang-format etc.
Fortunately the workaround for clangd is setting as "clangd.path": "/Users/mozilla/.mozbuild/clang/bin/clangd"
, but ./mach clang-format
can't be fixed this way.
Reporter | ||
Comment 1•2 years ago
|
||
Why do we need to install clang-tools separately when clang/bin
includes everything there?
Comment 2•2 years ago
|
||
The Bugbug bot thinks this bug should belong to the 'Firefox Build System::Bootstrap Configuration' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.
Comment 3•2 years ago
|
||
I think you just need to install Rosetta and it will work.
softwareupdate --install-rosetta
Reporter | ||
Comment 4•2 years ago
|
||
Sure, but bootstrap already gives everything in .mozbuild/clang/bin
in ARM64, there is no point to have x86-64 builds in .mozbuild/clang-tools/clang-tidy/bin/
.
Assignee | ||
Comment 5•2 years ago
|
||
clang-tools is built with extra patches for clang-tidy. Eventually, we'll use clang-tidy from clang + a plugin. In the meanwhile, this is where we're at.
Assignee | ||
Comment 6•2 years ago
|
||
Updated•2 years ago
|
Reporter | ||
Comment 7•2 years ago
|
||
Ah, that makes sense, thanks!
Pushed by mh@glandium.org: https://hg.mozilla.org/integration/autoland/rev/c5c6c2d8f509 Bootstrap the appropriate clang tidy on arm64 macos. r=firefox-build-system-reviewers,ahochheiden
Comment 9•2 years ago
|
||
bugherder |
Description
•