Closed
Bug 1486994
Opened 6 years ago
Closed 6 years ago
mach bootstrap installs x86-64 binaries on arm and arm64 linux
Categories
(Firefox Build System :: Bootstrap Configuration, enhancement)
Tracking
(firefox67 fixed)
RESOLVED
FIXED
mozilla67
Tracking | Status | |
---|---|---|
firefox67 | --- | fixed |
People
(Reporter: lth, Assigned: froydnj)
References
Details
Attachments
(1 file)
2.26 KB,
patch
|
lth
:
review+
|
Details | Diff | Splinter Review |
This pertains to whatever version of mach is in production as of Aug 28.
I have an ARM dev board that I use for spidermonkey development; I compile directly on the device. mach bootstrap is useful for getting things set up, but it downloads x86-64 binaries of cbindgen, clang, and node.
(Also it fails to configure rust properly; it errors out. I have not dug deeply here but it looks like it downloads an x86-64 version of rustup-init and attempts to run that.)
I don't necessarily expect arm binaries to be provided; error messages saying packages could not be downloaded for the architecture (and maybe here's how you install them manually) would be adequate, probably.
Reporter | ||
Comment 1•6 years ago
|
||
Ditto for arm64, unsurprisingly.
arm64 is at least in principle powerful enough to build Firefox, it would be nice if bootstrap could at least check for a suitable architecture.
Summary: mach bootstrap installs x86-64 binaries on arm → mach bootstrap installs x86-64 binaries on arm and arm64
Comment 2•6 years ago
|
||
This now breaks things on our aarch64/arm64 windows devices, esp. the nodejs thing also breaks wanting to do an artifact build (for which I don't need clang or cbindgen, and shouldn't need rust (but bug 1525041).
Blocks: arm64-windows-bugs
Updated•6 years ago
|
Assignee | ||
Comment 3•6 years ago
|
||
(In reply to :Gijs (he/him) from comment #2)
This now breaks things on our aarch64/arm64 windows devices, esp. the nodejs thing also breaks wanting to do an artifact build (for which I don't need clang or cbindgen, and shouldn't need rust (but bug 1525041).
Can you file a separate bug for the windows case? The fixes are going to be different between the Linux case and the Windows case, and I think it's worth getting separate bugs for them.
Flags: needinfo?(gijskruitbosch+bugs)
Comment 4•6 years ago
|
||
Filed bug 1525069. Unblocking this from the windows metabug then; sorry for the noise!
No longer blocks: aarch64-windows
Flags: needinfo?(gijskruitbosch+bugs)
Updated•6 years ago
|
Summary: mach bootstrap installs x86-64 binaries on arm and arm64 → mach bootstrap installs x86-64 binaries on arm and arm64 linux
Assignee | ||
Comment 5•6 years ago
|
||
Presumably, if somebody is working on a non-x86-64 Linux box, they know
enough to install all of these packages manually.
Attachment #9041265 -
Flags: review?(lhansen)
Reporter | ||
Comment 6•6 years ago
|
||
Comment on attachment 9041265 [details] [diff] [review]
avoid automatic installs of taskcluster packages on non-x86-64 machines
Review of attachment 9041265 [details] [diff] [review]:
-----------------------------------------------------------------
Looks right to me. Thanks for fixing this!
Attachment #9041265 -
Flags: review?(lhansen) → review+
Pushed by nfroyd@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/609025fde719
avoid automatic installs of taskcluster packages on non-x86-64 machines; r=lth
Comment 8•6 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox67:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla67
Updated•6 years ago
|
Assignee: nobody → nfroyd
You need to log in
before you can comment on or make changes to this bug.
Description
•