Closed
Bug 1797679
Opened 3 years ago
Closed 3 years ago
Fall back to launching a new tab for the origin domain of abandoned Windows native notifications.
Categories
(Toolkit Graveyard :: Notifications and Alerts, enhancement, P2)
Tracking
(firefox110 fixed)
RESOLVED
FIXED
110 Branch
| Tracking | Status | |
|---|---|---|
| firefox110 | --- | fixed |
People
(Reporter: nrishel, Assigned: nrishel)
References
Details
(Whiteboard: [fidedi])
Attachments
(2 files, 2 obsolete files)
Currently abandoned native notifications are logged but otherwise unhandled. We can't fully recover to handle the original intended interaction, but we can bring the user back to the originating domain.
| Assignee | ||
Updated•3 years ago
|
Whiteboard: [fidedi]
Updated•3 years ago
|
| Assignee | ||
Comment 1•3 years ago
|
||
Depends on D160458
| Assignee | ||
Comment 2•3 years ago
|
||
Depends on D160459
Updated•3 years ago
|
Attachment #9300493 -
Attachment description: Bug 1797679 - Pre: Don't open a new window when a Firefox instance existed prior to the notification server attempting to launch Firefox. r=nalexander → Bug 1797679 - Pre: Cleanup notification handling in `BrowserContentHandler.jsm`, remove unnecessary `preventDefault` and nest `launchArg` handling in its check. r=nalexander
Updated•3 years ago
|
Attachment #9300493 -
Attachment description: Bug 1797679 - Pre: Cleanup notification handling in `BrowserContentHandler.jsm`, remove unnecessary `preventDefault` and nest `launchArg` handling in its check. r=nalexander → Bug 1797679 - Pre: Cleanup notification handling in `BrowserContentHandler.jsm`, clarify conditions where `preventDefault` is necessary and nest `launchArg` handling in its check. r=nalexander
Updated•3 years ago
|
Attachment #9300493 -
Attachment description: Bug 1797679 - Pre: Cleanup notification handling in `BrowserContentHandler.jsm`, clarify conditions where `preventDefault` is necessary and nest `launchArg` handling in its check. r=nalexander → Bug 1797679 - Pre 1: Don't open a new window when a Firefox instance existed prior to the notification server attempting to launch Firefox. r=nalexander
| Assignee | ||
Comment 3•3 years ago
|
||
Depends on D160459
Updated•3 years ago
|
Attachment #9304804 -
Attachment is obsolete: true
Updated•3 years ago
|
Attachment #9300493 -
Attachment is obsolete: true
Updated•3 years ago
|
Attachment #9300494 -
Attachment description: Bug 1797679 - Fall back to launching a new tab to the host port for Windows native notifications abandoned due to closed tabs. r=nalexander → WIP: Bug 1797679 - Fall back to launching a new tab to the host port for Windows native notifications abandoned due to closed tabs. r=nalexander
| Assignee | ||
Comment 4•3 years ago
|
||
When a notification's originating tab is closed, it remains in the action center and launches to the originating domain when clicked. When the notification is from a private browsing session, the originating domain leaks to a non-private context when a private browsing session is still active. This fixes the leak by closing the notification with it's originating tab.
Updated•3 years ago
|
Attachment #9300494 -
Attachment description: WIP: Bug 1797679 - Fall back to launching a new tab to the host port for Windows native notifications abandoned due to closed tabs. r=nalexander → Bug 1797679 - Fall back to launching a new tab to the host port for Windows native notifications abandoned due to closed tabs. r=nalexander
Updated•3 years ago
|
Attachment #9307462 -
Attachment description: WIP: Bug 1797679 - Post: Prevent Windows notifications from leaking URL from private browsing session. r=nalexander → Bug 1797679 - Post: Prevent Windows notifications from leaking URL from private browsing session. r=nalexander
Pushed by nrishel@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/c619d8a832cb
Fall back to launching a new tab to the host port for Windows native notifications abandoned due to closed tabs. r=nalexander
https://hg.mozilla.org/integration/autoland/rev/d59c1d65bc30
Post: Prevent Windows notifications from leaking URL from private browsing session. r=nalexander
Comment 6•3 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/c619d8a832cb
https://hg.mozilla.org/mozilla-central/rev/d59c1d65bc30
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
status-firefox110:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 110 Branch
Updated•2 years ago
|
Product: Toolkit → Toolkit Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•