1797703 - fixed positioned elements are broken on several websites

Status: VERIFIED FIXED

(Core :: Layout, defect, P1)

Description

[Sören Hentzschel]

[Tracking Requested - why for this release]:

Fixed positioned elements are broken on several websites. To give you two examples:

Example 1:

1. Open https://www.grossarlerhof.at/de/wohnen/angebote/auszeit-vom-alltag-4-3-so-do-~p95
2. Press the large button to accept cookies
3. Scroll down and up

Expected:

A bar with icons and buttons is fixed to the bottom of the window.

Actual:

The bar is not fixed to the bottom. Instead it's shown on the wrong position. (Sometimes it works, so maybe you have to reload a few times to reproduce the issue).

Example 2:

1. Open https://forum.netcup.de/ (it uses a popular forum software so potentially many websites are affected)
2. Scroll a bit down
3. Press the top link "Anmelden oder registrieren"

Expected:

Fully visible dialog and the background mask is above the whole window.

Actual:

The dialog is truncated at top and the background mask does not cover the whole window.

Comment 1

[Sören Hentzschel]

Attachment: broken example 1

Comment 2

[Sören Hentzschel]

Attachment: broken example 2

Comment 3

[Emilio Cobos Álvarez (:emilio)]

I believe https://searchfox.org/mozilla-central/rev/2d1097c27f31cb15f7588b043d691cda9710d14b/layout/base/nsCSSFrameConstructor.cpp#1318 was incorrectly moved inside of the if condition.

Comment 4

[Fanolian]

Attachment: Tree Style tab pinned tabs.png

Tree Style Tab's pinned tab do not display correctly for 2nd+ pinned tabs.

STR:

1. Install Tree Style Tab.
2. Pinned 2 or more tabs.
3. Press F1 to close and reopen Tree Style Tab tab bar.

This is regressed by bug 1797011 so maybe it is the same issue as comment 0.

Comment 5

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1797703 - Fix frame constructor save state restoration. r=TYLin

Comment 7

[Ting-Yu Lin [:TYLin] (PST, UTC-8)]

Emilio has a patch to fix this bug.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4dfea46f3cd0
Fix frame constructor save state restoration. r=TYLin,layout-reviewers

Comment 9

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/36698 for changes under testing/web-platform/tests

Comment 10

[Noemi Erli[:noemi_erli]]

Backed out changeset 4dfea46f3cd0 (Bug 1797703) for causing reftest failures

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&collapsedPushes=842382&selectedTaskRun=Nfz0WWbSQqy1gHwP3wj16w.0&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=4dfea46f3cd01c2134c9f1034136e3a065cc81cd

Log: https://treeherder.mozilla.org/logviewer?job_id=394608395&repo=autoland&lineNumber=9099

Backout: https://hg.mozilla.org/integration/autoland/rev/308d2e5dbf05896e839f48ad806de50c75e4b7b3

Comment 11

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR was closed without merging

Comment 12

[Ting-Yu Lin [:TYLin] (PST, UTC-8)]

Attachment: Bug 1797703 - Fix frame constructor save state restoration. r?emilio

Restore the old logic [1] prior to introducing Bug 1797011 Part 2.

[1] https://searchfox.org/mozilla-central/rev/85cbcecd24554c1fa88360412452ad0f7ed48630/layout/base/nsCSSFrameConstructor.cpp#1309-1335
[2] https://hg.mozilla.org/mozilla-central/rev/3f443cbb5bdd

The wpt test is written by Emilio Cobos Álvarez <[e-mail]> in
https://phabricator.services.mozilla.com/D160523.

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4ce77511413a
Fix frame constructor save state restoration. r=emilio

Comment 14

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/4ce77511413a

Comment 15

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot

Comment 18

[Ardelean Oana, Desktop Test Engineering [:oardelean]]

Reproducible on a 2022-10-27 Nightly build on macOS 12 using the STR from Comment 0 and Comment 4. Confirming that all 3 issues are fixed on Firefox 108.0b2(build ID: 20221115200658) and Nightly 109.0a1(build ID: 20221116182402) on macOS 12, Windows 10, Ubuntu 22.