1797759 - ESLint jobs in CI show failures in the log, but Treeherder shows successful/green status

Status: RESOLVED FIXED

(Thunderbird :: Testing Infrastructure, defect, P1)

Description

[Rob Lemley [:rjl]]

On today's Daily build, the ESLint linting job shows up green in Treeherder, but the log shows errors: https://treeherder.mozilla.org/logviewer?job_id=394520310&repo=comm-central

[task 2022-10-27T10:32:06.050Z] 10:32:06.50 eslint (74) | Finished in 106.87 seconds
[task 2022-10-27T10:32:06.061Z] TEST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/comm/calendar/test/browser/timezones/browser_timezones.js:91:11 | Octal literals should not be used. (no-octal)
[task 2022-10-27T10:32:06.061Z] TEST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/comm/calendar/test/browser/timezones/browser_timezones.js:101:11 | Octal literals should not be used. (no-octal)
[task 2022-10-27T10:32:06.061Z] TEST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/comm/calendar/test/browser/timezones/browser_timezones.js:111:11 | Octal literals should not be used. (no-octal)
[task 2022-10-27T10:32:06.061Z] TEST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/comm/calendar/test/browser/timezones/browser_timezones.js:121:11 | Octal literals should not be used. (no-octal)
[task 2022-10-27T10:32:06.061Z] TEST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/comm/calendar/test/browser/timezones/browser_timezones.js:131:11 | Octal literals should not be used. (no-octal)
[task 2022-10-27T10:32:06.061Z] TEST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/comm/calendar/test/browser/timezones/browser_timezones.js:141:11 | Octal literals should not be used. (no-octal)
[task 2022-10-27T10:32:06.061Z] TEST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/comm/calendar/test/browser/timezones/browser_timezones.js:151:11 | Octal literals should not be used. (no-octal)
[task 2022-10-27T10:32:06.061Z] TEST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/comm/calendar/test/browser/timezones/browser_timezones.js:161:11 | Octal literals should not be used. (no-octal)
[taskcluster 2022-10-27 10:32:06.515Z] === Task Finished ===

Comment 1

[Rob Lemley [:rjl]]

Attachment: Bug 1797759 - Return the result of commands.dispatch from commlint mach command. r=#thunderbird-reviewers

"mach commlint"d was silently discarding the return value of the real "mach lint"
command. Because of that, the exit code from running "mach commlint" was always
zero. Treeherder would then display test runs as green/successful. "mach commlint"
just needs to return the value from commands.dispatch() so that mach itself
exits with an error status when necessary.
This has been affecting CI ESLint jobs since bug 1793625. In that bug, the
ESLint job was changed to run "mach commlint" instead of "mach eslint".
Other mozlint jobs in CI were not affected because they ran with "mach lint
--config-path=comm/tools/lint". That's the "old" way of using the comm/tools/lint
configurations prior to the addition of "mach commlint". Since it didn't use
the "mach commlint" code, the bug wasn't triggered and runs with failures exited
as such.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/642483c708d7
Return the result of commands.dispatch from commlint mach command. r=freaktechnik