1797952 - Network response tab won't render if there is a html link

Status: VERIFIED FIXED

(DevTools :: Netmonitor, defect, P2)

Description

[dario.sobrino]

Attachment: Broken Firefox Developer Edition.png

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:107.0) Gecko/20100101 Firefox/107.0

Steps to reproduce:

Render a simple link with the following code: <a href="#" title="test">Hello</a>

I've narrowed it down to the link issue. I was trying to output some data for debugging. You can include more code. Won't render as long as there is a link there.

Actual results:

No preview whatsoever. The preview is blank. The code is there though as raw content.

It doesn't matter if there are any other html elements. The preview will show nothing whenever there is a link there.

Expected results:

It should have rendered the code just like any other firefox version. This started happening after the upgrade to the 107 version.

It still happens in the 108.0a1 nightly that I just intalled to check if it was fixed.

Comment 1

[Julian Descottes [:jdescottes]]

We are missing ;charset=UTF-8 from the data URL.

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1640689

Comment 3

[Julian Descottes [:jdescottes]]

Attachment: Bug 1797952 - [devtools] Fix netmonitor HTML previews with line breaks or special characters

Add charset=UTF8 to the data url used for the iframe preview + encodeURIComponent

Comment 4

[Donal Meehan [:dmeehan]]

:jdescottes the final 107 beta builds tomorrow 2022-11-03
Would like to avoid shipping this regression in 107 - if this patch is ready, landed, and we get a beta uplift request?

Comment 5

[Julian Descottes [:jdescottes]]

(In reply to Donal Meehan [:dmeehan] from comment #4)

:jdescottes the final 107 beta builds tomorrow 2022-11-03
Would like to avoid shipping this regression in 107 - if this patch is ready, landed, and we get a beta uplift request?

Thanks for the ping! I'll address the review comments ASAP and will land + request uplift.

Comment 6

[Julian Descottes [:jdescottes]]

Comment on attachment 9301091 [details]
Bug 1797952 - [devtools] Fix netmonitor HTML previews with line breaks or special characters

Beta/Release Uplift Approval Request

• User impact if declined: The preview panel in the DevTools network tab is blank for most html content. The main use case for this feature is to easily visualize server error pages, so fixing this would be nice.

Not verified yet, I just pushed the patch to autoland. I can verify as soon as it reaches central.

• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Covered by automated tests, DevTools-only change. We are adding a charset + encoding the content of a data-url used as the source of the preview iframe.
• String changes made/needed:
• Is Android affected?: No

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/63cbc84cfd86
[devtools] Fix netmonitor HTML previews with line breaks or special characters r=ochameau

Comment 8

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/63cbc84cfd86

Comment 9

[Julian Descottes [:jdescottes]]

Verified on latest Nightly.

Comment 10

[dario.sobrino]

Indeed, just checked the nightly and it works. Thanks guys.

Comment 11

[Donal Meehan [:dmeehan]]

Comment on attachment 9301091 [details]
Bug 1797952 - [devtools] Fix netmonitor HTML previews with line breaks or special characters

Approved for 107.0b9

Comment 12

[Donal Meehan [:dmeehan]]

https://hg.mozilla.org/releases/mozilla-beta/rev/f0656ba14fa3