1798178 - Downloading a txt file from b.m.o does not trigger the "completed download" animation, and the file is not added to the Downloads list

Status: VERIFIED FIXED

(Core :: DOM: Networking, defect)

Description

[Mayank Bansal]

Create fresh Nightly profile
Go to https://bugzilla.mozilla.org/show_bug.cgi?id=1728590
Right click on the attached Testcase->Save Link As->Save

ER: A "download is completed" animation should be triggered, and a download panel/button should appear in the Toolbar that would allow me to open the downloaded file.
AR: No animation is triggered

Regression:
Bug 1785331 - Allow Synthesized Request Bypass ORB checks r=smaug,valentin,necko-reviewers

If ORB doesn't block the request from service worker, then the
synthesized request should also not be blocked by ORB.

Differential Revision: https://phabricator.services.mozilla.com/D160382

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1785331

:sefeng, since you are the author of the regressor, bug 1785331, could you take a look? Also, could you set the severity field?

For more information, please visit auto_nag documentation.

Comment 2

[bloonyapprentice]

I want to add that this also affects downloading raw files from GitHub. The files are actually silently downloaded, but they are 0 bytes files which clutter the Downloads folder. Also, if you open the link, right-click and use "Save Page As...", the files can be successfully downloaded.

Comment 3

[Sean Feng [:sefeng211]]

Attachment: Bug 1798178 - Allow ORB ignores save link downloads r=smaug

There's no point of blocking requests that users want to download,
and these requests are only being handled the parent process.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fb256b849de8
Allow ORB ignores save link downloads r=necko-reviewers,valentin

Comment 5

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/fb256b849de8

Comment 6

[Rolland Eduard Rus]

Reproduced the issue on Nightly 108.0a1 build from 2022-10-29 on MacOS 12 ARM, Windows 10, WIndows 11 and Ubuntu 22.
Verified it on Beta 108.0b2 build on MacOS 12 ARM, Windows 10, WIndows 11 and Ubuntu 22, and can confirm that the issue is fixed.