179827 - b.m.o, lxr, and m.o need to disable aggregated queries from the sidebar

Status: RESOLVED WORKSFORME

(bugzilla.mozilla.org :: General, defect)

Description

[Bradley Baetz (:bbaetz)]

As discussed in bug 179500, people appear to be selecting all search engines,
and os bugzilla gets hits meant for google + friends. Due to the query being a
silly one anyway, plus a bugzilla bug in bracketing the epxressions for the sql
generation (bug 179697), this query is horrible sql, and is even worse now that
product/components have a join which mysq can't optimsie due to this bracking error.

Since aggregating bugzilla queries with google is silly, bmo should block this.
multiple engine searches have the header 'MultiSearch: true', so the following
rewriterules in the .htaccess should work:

  RewriteEngine On
  RewriteCond %{HTTP:MultiSearch} ^True$ [NC]
  RewriteRule ^buglist.cgi$ disabled.html

The first line turns rewriting on.
The second looks for a MultiSearch header which matches 'True' wiothout caring
about case. Even though we know the case for mozilla, making this
case-insensitive gives some futureproofing
The third line converts buglist.cgi requests into a lookup on disabled.html,
where disabled.html should be a static html page in the same directory
explaining why the search is blocked. You don't ahve to be too details; people
won't see this result unless the specifically ask for it.

You could also use |http://bugzilla.mozilla.org/disabled.html [R]| if you wanted
to issue a redirect; the main advantage of that is that you could have something
to grep the logs on to see how often this was happening. This does have the cost
of an etra server hit, though, and the existing search shouldn't have too many
false positives anyway.

Comment 1

[Myk Melez [:myk] [@mykmelez]]

Done.  Leaving the bug open so I remember to remove the [R] and fix LXR and m.o
as well.

Comment 2

[Bradley Baetz (:bbaetz)]

Just for hte record, teh last line ended up being

  RewriteRule ^/buglist.cgi$ /disabled.html

because it got added to httpd.conf, rather than .htaccess.

Comment 3

[Myk Melez [:myk] [@mykmelez]]

Removing the Bugzilla dependency since mothra has been fixed.

Comment 4

[Andreas Kunz]

After bug 234046 removed bugzilla search from Mozilla, this bug is fixed, no?

Comment 5

[Gervase Markham [:gerv]]

Assuming it's gone for good, I'd say so.

Gerv