179881 - requests link in footer should be 'my requests'

Status: RESOLVED FIXED

(Bugzilla :: Attachments & Requests, defect)

Description

[Bradley Baetz (:bbaetz)]

Theres currently a request link in the footer. It should default to requests
where the current user is the requestee.

The full current queue is too large to be of use to most people. If we had the
ability, makng it list requests made by the user would be good too, but we don't
(although a query.cgi option for 'show request queue' would probably be nice,
which would then allow 'preset request queries')

I'd prefer this to be a general thing, rather than a bmo footer.html.tmpl
customisation

Comment 1

[Myk Melez [:myk] [@mykmelez]]

Attachment: patch v1: implements feature

Notes:

1. Added "do_union" parameter that changes request query from intersection of
filter criteria (requestee=myk AND flag=review) to union (requestee=myk OR
flag=review) so we can do "requestee=myk OR requester=myk" and get flags I
requested as well as flags that have been requested of me.

2. Turned off column exclusion if we're doing a union since we can no longer
guarantee the same value will appear in that column.

3. Added debug output to the template.

Comment 2

[Bradley Baetz (:bbaetz)]

Comment on attachment 106718 [details] [diff] [review]
patch v1: implements feature

Err, theres no patch here...

Comment 3

[Myk Melez [:myk] [@mykmelez]]

Attachment: err, the real patch v1

Comment 4

[Bradley Baetz (:bbaetz)]

Comment on attachment 106732 [details] [diff] [review]
err, the real patch v1


>Index: request.cgi

>+    #$::FORM{'status'} ||= "?";
>+    #if ($::FORM{'status'} eq "+-") {
>+    #    push(@criteria, "flags.status IN ('+', '-')");
>+    #    push(@excluded_columns, 'status') unless $::FORM{'do_union'};
>+    #}
>+    #elsif ($::FORM{'status'} ne "all") {
>+    #    push(@criteria, "flags.status = '$::FORM{'status'}'");
>+    #    push(@excluded_columns, 'status') unless $::FORM{'do_union'};
>+    #}

Why is this now disabled?

>     # Filter results by exact product or component.
>     if (defined($::FORM{'product'}) && $::FORM{'product'} ne "") {
>         my $product_id = get_product_id($::FORM{'product'});
>         if ($product_id) {
>-            $query .= " AND bugs.product_id = $product_id";
>-            push(@excluded_columns, 'product');
>+            push(@criteria, "bugs.product_id = $product_id");
>+            push(@excluded_columns, 'product') unless $::FORM{'do_union'};

Hmm. This is hacky, but then so is all of this patch :) theres that separate
bug on using Bugzilla::Search, I guess.

>             if (defined($::FORM{'component'}) && $::FORM{'component'} ne "") {
>                 my $component_id = get_component_id($product_id, $::FORM{'component'});
>                 if ($component_id) {
>-                    $query .= " AND bugs.component_id = $component_id";
>-                    push(@excluded_columns, 'component');
>+                    push(@criteria, "bugs.component_id = $component_id");
>+                    push(@excluded_columns, 'component') unless $::FORM{'do_union'};

This is even more hacky, though.

As long as there isn't any UI for do_union, I think we can let this live for
now.

>Index: template/en/default/request/queue.html.tmpl

>+
>+[% PROCESS global/header.html.tmpl 
>+  title="Request Queue"
>+  h2=filter_form
>+  style = "
>+    table.requests th { text-align: left; }
>+    table#filter th { text-align: right; }
>+  "
>+%]
>+

Why does this need to be moved?

>+[% IF debug %]
>+  <p>[% query %]</p>

FILTER html

Comment 5

[Myk Melez [:myk] [@mykmelez]]

Attachment: patch v2: review fixes

>Why is this now disabled?

Because my patch broke it (since it explicitly searches for status='?'), and
because there's no UI for it.  This version fixes and enables it again.


>Why does this need to be moved?

It doesn't, it just looked better that way.


>FILTER html

Fixed.

Comment 6

[Bradley Baetz (:bbaetz)]

Comment on attachment 106757 [details] [diff] [review]
patch v2: review fixes

Hacky, hacky, hacky :)

IF you can find it, add a comment pointing to the bug to make this code use
Bugzilla::Search. I can't find it, although I'm reasonably certain that I did
file it. Its sort of implied in bug 179489, though, so maybe thats what I'm
thinking of.

Comment 7

[Myk Melez [:myk] [@mykmelez]]

Checking in template/en/default/global/useful-links.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/global/useful-links.html.tmpl,v
 <--  useful-links.html.tmpl
new revision: 1.14; previous revision: 1.13
done
Checking in request.cgi;
/cvsroot/mozilla/webtools/bugzilla/request.cgi,v  <--  request.cgi
new revision: 1.4; previous revision: 1.3
done
Checking in template/en/default/request/queue.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/request/queue.html.tmpl,v
 <--  queue.html.tmpl
new revision: 1.6; previous revision: 1.5
done

Comment 8

[Tobias Burnus]

Attachment: Change '&' to to '&' in order to be HTML 4 conform

I don't want to be picky but shouldn't this be '&' rather than '&'

> + | <a href="request.cgi?requester=[% email %]&requestee=[% email
%]&do_union=1&group=type">My Requests</a>

Comment 9

[Bradley Baetz (:bbaetz)]

Comment on attachment 106782 [details] [diff] [review]
Change '&' to to '&' in order to be HTML 4 conform

Doh, can't believe I missed that. r=bbaetz

Comment 10

[Bradley Baetz (:bbaetz)]

Checked in