1798819 - Nightly icon on Windows is using private browsing icon even when not in PBM

Status: RESOLVED DUPLICATE of bug 1797806

(Firefox :: Private Browsing, defect)

Description

[Emilio Cobos Álvarez (:emilio)]

Mozregression points to https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=7e6ddb806ce0cdaea5d6cbb3cc21581f8d09c541&tochange=bfc380f167f3be93b4cab989343afeeddc0a0ec2

Comment 1

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1798819 - Only set PBM icon+AUMID iff the window is actually private. r=bhearsum,mhowell

There should be no need to check if PBM is allowed at this point, but we
do still need to check mIsPrivate.

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1797806

Comment 4

[Aryan]

Possible hour of fix to avoid the confusion of users?

Comment 5

[mmis1000]

It seems this update also purged normal firefox shortcut for some reason. I now have two shortcut to "private_browsing.exe". And 0 to normal "firefox.exe".

Comment 6

[wdarea51]

I would like to add that I came here specifically searching for this issue because I could not figure out why I was only seeing the private browsing icon in my taskbar on the latest firefox nightly 108. Definitely not an isolated issue it seems. Just wanted to say I have tried to delete the shortcut and re-add it and that did not fix it. I tried specifically adding the desktop shortcut to the taskbar and it would still show up as the private browsing icon.

Comment 7

[[e-mail] (:bhearsum)]

(In reply to wdarea51 from comment #6)

I would like to add that I came here specifically searching for this issue because I could not figure out why I was only seeing the private browsing icon in my taskbar on the latest firefox nightly 108. Definitely not an isolated issue it seems. Just wanted to say I have tried to delete the shortcut and re-add it and that did not fix it. I tried specifically adding the desktop shortcut to the taskbar and it would still show up as the private browsing icon.

This was caused by https://bugzilla.mozilla.org/show_bug.cgi?id=1797806, which has been reverted. It should be fixed in the latest nightly. I'm going to dupe this bug over there, where I'm dealing with a better fix for the issue.