1798908 - SitePermsAddonProvider.shutdown should only call Services.obs.removeObserver for the "perf-changed" topic if its lazyInit method was actually called

Status: RESOLVED FIXED

(Toolkit :: Add-ons Manager, defect, P2)

Description

[Luca Greco [:rpl] [:luca] [:lgreco]]

I noticed that SitePermsAddonProvider.shutdown was throwing from the call to Services.obs.removeObserver in an unrelated xpcshell test I was working on.

Services.obs.removeObserver will be throwing when there isn't an observer actually registered, and that happens if lazyInit has never been actually called (e.g. because the provider's getAddonsByType and getAddonByID methods are never been called), and so we should check if this._initPromise is set and do not call Services.obs.removeObserver if it isn't.

Comment 1

[Luca Greco [:rpl] [:luca] [:lgreco]]

Attachment: Bug 1798908 - SitePermsAddonProvider.shutdown should not call Services.obs.removeObserver if this._initPromise is not set. r?nchevobbe!

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d48dd230d8d4
SitePermsAddonProvider.shutdown should not call Services.obs.removeObserver if this._initPromise is not set. r=nchevobbe

Comment 3

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/d48dd230d8d4