Closed Bug 1798917 Opened 25 days ago Closed 20 days ago

Convert pseudo-private UrlbarView properties and methods to be truly private

Categories

(Firefox :: Address Bar, task, P1)

task
Points:
3

Tracking

()

RESOLVED FIXED
108 Branch
Tracking Status
firefox108 --- fixed

People

(Reporter: dao, Assigned: dao, NeedInfo)

References

(Blocks 1 open bug)

Details

(Whiteboard: [snt-urlbar-result-menu])

Attachments

(1 file)

Nowadays Javascript classes can have truly private properties and methods using the # prefix. We should use that instead of the current unenforced _ naming convention.

Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/ca4db8d37ef9
Convert pseudo-private UrlbarView properties and methods to be truly private. r=mak
Status: ASSIGNED → RESOLVED
Closed: 20 days ago
Resolution: --- → FIXED
Target Milestone: --- → 108 Branch
See Also: → 1799847

Private members make it kinda hard to debug and experiment with stuff in the browser console. Before we convert a lot of these, could we consider the feasibility of allowing some kind of bypass in certain contexts? I imagine that'd be a spidermonkey thing if it's possible. Also I think Searchfox doesn't know how to parse private field names yet, so the sticky highlighter doesn't work on them

(In reply to Shane Hughes [:aminomancer] from comment #4)

Private members make it kinda hard to debug and experiment with stuff in the browser console. Before we convert a lot of these, could we consider the feasibility of allowing some kind of bypass in certain contexts? I imagine that'd be a spidermonkey thing if it's possible.

Good point and interesting idea. Could you please file a devtools or spidermonkey bug on this?

Also I think Searchfox doesn't know how to parse private field names yet, so the sticky highlighter doesn't work on them

And on this too? We do seem to have a component for Searchfox: https://bugzilla.mozilla.org/enter_bug.cgi?product=Webtools&component=Searchfox

Flags: needinfo?(shughes)
See Also: → 1801960
See Also: → 1801966
You need to log in before you can comment on or make changes to this bug.