1799111 - [css-grid] Grid items crossing flexible tracks should not participate in auto min sizing

Status: RESOLVED FIXED

(Core :: Layout: Grid, enhancement)

Description

[Tiaan Louw]

Bug that tracks part of Bug 1530097.

Comment 1

[Tiaan Louw]

Attachment: Bug 1799111 - Don't apply auto min sizing when spanning flexible tracks. r=emilio

This is the first part of the bug. A clarification in the spec states
that a grid item spanning multiple tracks, which include a flexible
track, should not participate in auto min sizing calculation and should
have a width of 0.

https://w3c.github.io/csswg-drafts/css-grid-1/#min-size-auto

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b2e56f907f70
Don't apply auto min sizing when spanning flexible tracks. r=emilio

Comment 3

[Cristian Tuns]

Backed out for causing reftest failures on grid-track-fit-content-sizing-001.html

• Backout link
• Push with failures
• Failure Log
• Failure line: REFTEST TEST-UNEXPECTED-FAIL | layout/reftests/css-grid/grid-track-fit-content-sizing-001.html == layout/reftests/css-grid/grid-track-fit-content-sizing-001-ref.html | image comparison, max difference: 255, number of differing pixels: 640

Comment 4

[Tiaan Louw]

Not sure why reftests failed, investigating.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ec2ad590b148
Don't apply auto min sizing when spanning flexible tracks. r=emilio

Comment 6

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/ec2ad590b148

Comment 10

[Daniel Holbert [:dholbert]]

See bug 1530097 comment 17 - 18 -- I went through all of the dupes and webcompat issues associated with that bug, and I confirmed that they're all fixed* in Nightly 110 (and presumably 109 though I didn't test it), almost certainly due to the fix that landed in this bug here.

*In a few of the webcompat cases, the site had also been updated so that the issue had also gone away in older builds, so those were fixed for other reasons, but the original issue presumably would also have been fixed.

Comment 14

[Daniel Holbert [:dholbert]]

Transferring WebCompat Priority:P2 from bug 1530097, since this bug's patch seems to have fixed all the known WebCompat issues that were associated with that bug, per bug 1530097 comment 17 - 19.