Closed
Bug 1799140
Opened 3 years ago
Closed 3 years ago
Fix isort warnings on Python code
Categories
(Thunderbird :: Build Config, task, P3)
Thunderbird
Build Config
Tracking
(thunderbird_esr102 unaffected)
RESOLVED
FIXED
110 Branch
| Tracking | Status | |
|---|---|---|
| thunderbird_esr102 | --- | unaffected |
People
(Reporter: rjl, Assigned: rjl)
References
Details
Attachments
(1 file)
Bug 1790890 adds the flake8-isort plugin, with most rules set to warn rather than fail.
This bug is to clean up those warnings and allow the rules to be hard failures.
../mach commlint -l flake8 --fix . should do most of the work.
|
Assignee | |
Comment 1•3 years ago
|
||
isort is a separate linter now.
../mach commlint -l isort --fix .
Probably should run at the same time as the mass format in bug 1803829.
Summary: Fix flake8-isort warnings on Python code → Fix isort warnings on Python code
|
|
Assignee | |
Comment 2•3 years ago
|
||
Depends on D164733
|
||
Updated•3 years ago
|
Assignee: nobody → rob
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 3•3 years ago
|
||
Landing on comm-central
There's 2 changes in bug 1803829 that need to land with this one. They are stacked in Phabricator so they land in the right order.
Keywords: checkin-needed-tb
|
|
Assignee | |
Updated•3 years ago
|
Target Milestone: --- → 110 Branch
Pushed by thunderbird@calypsoblue.org:
https://hg.mozilla.org/comm-central/rev/fd87efc6fa3d
Fix isort lint warnings. r=aleca
|
||
Updated•3 years ago
|
You need to log in
before you can comment on or make changes to this bug.
Description
•