Closed
Bug 179932
Opened 22 years ago
Closed 22 years ago
Need getCFURL() on nsILocalFileMac
Categories
(Core :: XPCOM, defect)
Tracking
()
RESOLVED
FIXED
mozilla1.3alpha
People
(Reporter: ccarlen, Assigned: ccarlen)
References
Details
Attachments
(1 file)
|
3.87 KB,
patch
|
sdagley
:
review+
sfraser_bugs
:
superreview+
|
Details | Diff | Splinter Review |
1. CFURL is the recommended way to specify files these days. See
http://developer.apple.com/technotes/tn/tn2022.html.
2. It provides an easy way to get a UTF-8 Posix path from a file, even when the
nsILocalFile impl is the HFS impl. This is needed for bug 175876.
3. It would allow this code:
http://lxr.mozilla.org/seamonkey/source/embedding/components/printingui/src/mac/nsPrintingPromptServiceX.cpp#83
to be the same between XP_MAC and XP_MACOSX so that it could be enabled for
XP_MACOSX.
|
Assignee | |
Updated•22 years ago
|
Status: NEW → ASSIGNED
Target Milestone: --- → mozilla1.3alpha
|
|
Assignee | |
Comment 1•22 years ago
|
||
|
|
Assignee | |
Updated•22 years ago
|
Attachment #106092 -
Flags: superreview?(sfraser)
Attachment #106092 -
Flags: review?(sdagley)
|
||
Updated•22 years ago
|
Attachment #106092 -
Flags: review?(sdagley) → review+
|
||
Comment 2•22 years ago
|
||
Comment on attachment 106092 [details] [diff] [review]
patch
Patch looks good, but the comment for getCFURL needs to say that the caller
should CFRelease the returned CFURLRef.
Attachment #106092 -
Flags: superreview?(sfraser) → superreview+
|
|
Assignee | |
Comment 3•22 years ago
|
||
Checked in.
Status: ASSIGNED → RESOLVED
Closed: 22 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•