Closed Bug 1799374 Opened 3 years ago Closed 1 year ago

Intermittent /IndexedDB/idb-explicit-commit.any.html | single tracking bug

Categories

(Core :: Storage: IndexedDB, defect, P2)

defect

Tracking

()

RESOLVED FIXED
126 Branch
Tracking Status
firefox-esr115 --- wontfix
firefox123 --- wontfix
firefox124 --- wontfix
firefox125 --- wontfix
firefox126 --- fixed

People

(Reporter: intermittent-bug-filer, Assigned: janv)

References

(Regression)

Details

(Keywords: intermittent-failure, intermittent-testcase, regression)

Attachments

(6 files, 1 obsolete file)

Filed by: ctuns [at] mozilla.com
Parsed log: https://treeherder.mozilla.org/logviewer?job_id=395715874&repo=mozilla-central
Full log: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/aNn7vy0LQheMc7t8BwJ38Q/runs/0/artifacts/public/logs/live_backing.log


[task 2022-11-06T23:11:00.637Z] 23:11:00     INFO - TEST-PASS | /IndexedDB/idb-explicit-commit.any.html | Calling abort on a committed transaction throws and does not prevent persisting the data. 
[task 2022-11-06T23:11:00.637Z] 23:11:00     INFO - TEST-UNEXPECTED-TIMEOUT | /IndexedDB/idb-explicit-commit.any.html | Calling txn.commit() when txn is inactive should throw. - Test timed out
[task 2022-11-06T23:11:00.638Z] 23:11:00     INFO - 
[task 2022-11-06T23:11:00.638Z] 23:11:00     INFO - TEST-UNEXPECTED-NOTRUN | /IndexedDB/idb-explicit-commit.any.html | Transactions with same scope should stay in program order, even if one calls commit. - expected PASS
[task 2022-11-06T23:11:00.639Z] 23:11:00     INFO - 
[task 2022-11-06T23:11:00.639Z] 23:11:00     INFO - TEST-UNEXPECTED-NOTRUN | /IndexedDB/idb-explicit-commit.any.html | Transactions that explicitly commit and have errors should abort. - expected FAIL
[task 2022-11-06T23:11:00.640Z] 23:11:00     INFO - TEST-INFO | expected FAIL
[task 2022-11-06T23:11:00.641Z] 23:11:00     INFO - 
[task 2022-11-06T23:11:00.641Z] 23:11:00     INFO - TEST-UNEXPECTED-NOTRUN | /IndexedDB/idb-explicit-commit.any.html | Transactions that handle all errors properly should behave as expected when an explicit commit is called in an onerror handler. - expected PASS
[task 2022-11-06T23:11:00.642Z] 23:11:00     INFO - TEST-UNEXPECTED-TIMEOUT | /IndexedDB/idb-explicit-commit.any.html | expected ERROR
[task 2022-11-06T23:11:00.643Z] 23:11:00     INFO - TEST-INFO expected ERROR | took 10126ms
[task 2022-11-06T23:11:00.645Z] 23:11:00     INFO - PID 6772 | 1667776260636	Marionette	INFO	Stopped listening on port 49902
[task 2022-11-06T23:11:01.616Z] 23:11:01     INFO - PID 6772 | WARNING: A blocker encountered an error while we were waiting.
[task 2022-11-06T23:11:01.618Z] 23:11:01     INFO - PID 6772 |           Blocker:  Waiting for ping task
[task 2022-11-06T23:11:01.618Z] 23:11:01     INFO - PID 6772 |           Phase: TelemetryController: Waiting for pending ping activity
[task 2022-11-06T23:11:01.619Z] 23:11:01     INFO - PID 6772 |           State: (none)
[task 2022-11-06T23:11:01.620Z] 23:11:01     INFO - PID 6772 | WARNING: Error: Phase "profile-before-change" is finished, it is too late to register completion condition "OS.File: flush I/O queued before profileBeforeChange"
[task 2022-11-06T23:11:01.621Z] 23:11:01     INFO - PID 6772 | WARNING: addBlocker@resource://gre/modules/AsyncShutdown.jsm:703:15
[task 2022-11-06T23:11:01.621Z] 23:11:01     INFO - PID 6772 | addBlocker@resource://gre/modules/AsyncShutdown.jsm:511:26
[task 2022-11-06T23:11:01.622Z] 23:11:01     INFO - PID 6772 | addBlocker@resource://gre/modules/AsyncShutdown.jsm:450:15
[task 2022-11-06T23:11:01.622Z] 23:11:01     INFO - PID 6772 | setupShutdown@resource://gre/modules/osfile/osfile_async_front.jsm:1563:28
[task 2022-11-06T23:11:01.623Z] 23:11:01     INFO - PID 6772 | @resource://gre/modules/osfile/osfile_async_front.jsm:1583:16
[task 2022-11-06T23:11:01.623Z] 23:11:01     INFO - PID 6772 | @resource://gre/modules/osfile.jsm:12:30
[task 2022-11-06T23:11:01.624Z] 23:11:01     INFO - PID 6772 | @resource://gre/modules/TelemetryStorage.jsm:19:28
[task 2022-11-06T23:11:01.624Z] 23:11:01     INFO - PID 6772 | promiseArchivePing@resource://gre/modules/TelemetryArchive.jsm:103:5
[task 2022-11-06T23:11:01.625Z] 23:11:01     INFO - PID 6772 | promiseArchivePing@resource://gre/modules/TelemetryArchive.jsm:63:33
[task 2022-11-06T23:11:01.625Z] 23:11:01     INFO - PID 6772 | _submitPingLogic@resource://gre/modules/TelemetryControllerParent.jsm:554:48
[task 2022-11-06T23:11:01.626Z] 23:11:01     INFO - PID 6772 | send@resource://gre/modules/TelemetryControllerParent.jsm:642:24
[task 2022-11-06T23:11:01.627Z] 23:11:01     INFO - PID 6772 | submitExternalPing@resource://gre/modules/TelemetryControllerParent.jsm:182:17
[task 2022-11-06T23:11:01.628Z] 23:11:01     INFO - PID 6772 | sendPing@resource://gre/modules/EventPing.jsm:51:30
[task 2022-11-06T23:11:01.628Z] 23:11:01     INFO - PID 6772 | _submitPing@resource://gre/modules/EventPing.jsm:229:12
[task 2022-11-06T23:11:01.629Z] 23:11:01     INFO - PID 6772 | shutdown@resource://gre/modules/EventPing.jsm:112:10
[task 2022-11-06T23:11:01.630Z] 23:11:01     INFO - PID 6772 | _cleanupOnShutdown@resource://gre/modules/TelemetryControllerParent.jsm:954:31
[task 2022-11-06T23:11:01.630Z] 23:11:01     INFO - PID 6772 | shutdown/<@resource://gre/modules/TelemetryControllerParent.jsm:1024:24
[task 2022-11-06T23:11:01.631Z] 23:11:01     INFO - PID 6772 | observe@resource://gre/modules/AsyncShutdown.jsm:560:16
[task 2022-11-06T23:11:01.637Z] 23:11:01     INFO - PID 6772 | WARNING: A blocker encountered an error while we were waiting.
[task 2022-11-06T23:11:01.638Z] 23:11:01     INFO - PID 6772 |           Blocker:  Waiting for ping task
[task 2022-11-06T23:11:01.638Z] 23:11:01     INFO - PID 6772 |           Phase: TelemetryController: Waiting for pending ping activity
[task 2022-11-06T23:11:01.639Z] 23:11:01     INFO - PID 6772 |           State: (none)
[task 2022-11-06T23:11:01.640Z] 23:11:01     INFO - PID 6772 | WARNING: Error: Phase "profile-before-change" is finished, it is too late to register completion condition "OS.File: flush I/O queued before profileBeforeChange"
[task 2022-11-06T23:11:01.640Z] 23:11:01     INFO - PID 6772 | WARNING: addBlocker@resource://gre/modules/AsyncShutdown.jsm:703:15
[task 2022-11-06T23:11:01.641Z] 23:11:01     INFO - PID 6772 | addBlocker@resource://gre/modules/AsyncShutdown.jsm:511:26
[task 2022-11-06T23:11:01.642Z] 23:11:01     INFO - PID 6772 | addBlocker@resource://gre/modules/AsyncShutdown.jsm:450:15
[task 2022-11-06T23:11:01.643Z] 23:11:01     INFO - PID 6772 | setupShutdown@resource://gre/modules/osfile/osfile_async_front.jsm:1563:28
[task 2022-11-06T23:11:01.644Z] 23:11:01     INFO - PID 6772 | @resource://gre/modules/osfile/osfile_async_front.jsm:1583:16
[task 2022-11-06T23:11:01.644Z] 23:11:01     INFO - PID 6772 | @resource://gre/modules/osfile.jsm:12:30
[task 2022-11-06T23:11:01.645Z] 23:11:01     INFO - PID 6772 | @resource://gre/modules/TelemetryStorage.jsm:19:28
[task 2022-11-06T23:11:01.645Z] 23:11:01     INFO - PID 6772 | promiseArchivePing@resource://gre/modules/TelemetryArchive.jsm:103:5
[task 2022-11-06T23:11:01.646Z] 23:11:01     INFO - PID 6772 | promiseArchivePing@resource://gre/modules/TelemetryArchive.jsm:63:33
[task 2022-11-06T23:11:01.646Z] 23:11:01     INFO - PID 6772 | _submitPingLogic@resource://gre/modules/TelemetryControllerParent.jsm:554:48
[task 2022-11-06T23:11:01.647Z] 23:11:01     INFO - PID 6772 | send@resource://gre/modules/TelemetryControllerParent.jsm:642:24
[task 2022-11-06T23:11:01.647Z] 23:11:01     INFO - PID 6772 | submitExternalPing@resource://gre/modules/TelemetryControllerParent.jsm:182:17
[task 2022-11-06T23:11:01.648Z] 23:11:01     INFO - PID 6772 | saveShutdownPings@resource://gre/modules/TelemetrySession.jsm:982:34
[task 2022-11-06T23:11:01.649Z] 23:11:01     INFO - PID 6772 | shutdownChromeProcess/cleanup/<@resource://gre/modules/TelemetrySession.jsm:1232:20
[task 2022-11-06T23:11:01.650Z] 23:11:01     INFO - PID 6772 | cleanup@resource://gre/modules/TelemetrySession.jsm:1239:9
[task 2022-11-06T23:11:01.651Z] 23:11:01     INFO - PID 6772 | shutdownChromeProcess@resource://gre/modules/TelemetrySession.jsm:1256:14
[task 2022-11-06T23:11:01.651Z] 23:11:01     INFO - PID 6772 | shutdown@resource://gre/modules/TelemetrySession.jsm:247:17
[task 2022-11-06T23:11:01.652Z] 23:11:01     INFO - PID 6772 | _cleanupOnShutdown@resource://gre/modules/TelemetryControllerParent.jsm:973:35
[task 2022-11-06T23:11:01.653Z] 23:11:01     INFO - PID 6772 | observe@resource://gre/modules/AsyncShutdown.jsm:560:16
[task 2022-11-06T23:11:01.653Z] 23:11:01     INFO - PID 6772 | WARNING: A blocker encountered an error while we were waiting.
[task 2022-11-06T23:11:01.653Z] 23:11:01     INFO - PID 6772 |           Blocker:  TelemetryController: shutting down
[task 2022-11-06T23:11:01.654Z] 23:11:01     INFO - PID 6772 |           Phase: profile-before-change-telemetry
[task 2022-11-06T23:11:01.655Z] 23:11:01     INFO - PID 6772 |           State: Error getting state: Error: Phase "profile-before-change" is finished, it is too late to register completion condition "OS.File: flush I/O queued before profileBeforeChange" at addBlocker@resource://gre/modules/AsyncShutdown.jsm:703:15
[task 2022-11-06T23:11:01.655Z] 23:11:01     INFO - PID 6772 | addBlocker@resource://gre/modules/AsyncShutdown.jsm:511:26
[task 2022-11-06T23:11:01.656Z] 23:11:01     INFO - PID 6772 | addBlocker@resource://gre/modules/AsyncShutdown.jsm:450:15
[task 2022-11-06T23:11:01.657Z] 23:11:01     INFO - PID 6772 | setupShutdown@resource://gre/modules/osfile/osfile_async_front.jsm:1563:28
[task 2022-11-06T23:11:01.657Z] 23:11:01     INFO - PID 6772 | @resource://gre/modules/osfile/osfile_async_front.jsm:1583:16
[task 2022-11-06T23:11:01.658Z] 23:11:01     INFO - PID 6772 | @resource://gre/modules/osfile.jsm:12:30
[task 2022-11-06T23:11:01.658Z] 23:11:01     INFO - PID 6772 | @resource://gre/modules/TelemetryStorage.jsm:19:28
[task 2022-11-06T23:11:01.659Z] 23:11:01     INFO - PID 6772 | getShutdownState@resource://gre/modules/TelemetrySend.jsm:1687:7
[task 2022-11-06T23:11:01.659Z] 23:11:01     INFO - PID 6772 | getShutdownState@resource://gre/modules/TelemetrySend.jsm:369:30
[task 2022-11-06T23:11:01.660Z] 23:11:01     INFO - PID 6772 | _getState@resource://gre/modules/TelemetryControllerParent.jsm:1072:38
[task 2022-11-06T23:11:01.660Z] 23:11:01     INFO - PID 6772 | setupTelemetry/<@resource://gre/modules/TelemetryControllerParent.jsm:931:18
[task 2022-11-06T23:11:01.661Z] 23:11:01     INFO - PID 6772 | safeGetState@resource://gre/modules/AsyncShutdown.jsm:242:17
[task 2022-11-06T23:11:01.661Z] 23:11:01     INFO - PID 6772 | Barrier/addBlocker/promise<@resource://gre/modules/AsyncShutdown.jsm:751:20
[task 2022-11-06T23:11:01.662Z] 23:11:01     INFO - PID 6772 | observe@resource://gre/modules/AsyncShutdown.jsm:560:16
[task 2022-11-06T23:11:01.663Z] 23:11:01     INFO - PID 6772 | WARNING: Error: Phase "profile-before-change" is finished, it is too late to register completion condition "OS.File: flush I/O queued before profileBeforeChange"
[task 2022-11-06T23:11:01.663Z] 23:11:01     INFO - PID 6772 | WARNING: addBlocker@resource://gre/modules/AsyncShutdown.jsm:703:15
[task 2022-11-06T23:11:01.664Z] 23:11:01     INFO - PID 6772 | addBlocker@resource://gre/modules/AsyncShutdown.jsm:511:26
[task 2022-11-06T23:11:01.665Z] 23:11:01     INFO - PID 6772 | addBlocker@resource://gre/modules/AsyncShutdown.jsm:450:15
[task 2022-11-06T23:11:01.665Z] 23:11:01     INFO - PID 6772 | setupShutdown@resource://gre/modules/osfile/osfile_async_front.jsm:1563:28
[task 2022-11-06T23:11:01.665Z] 23:11:01     INFO - PID 6772 | @resource://gre/modules/osfile/osfile_async_front.jsm:1583:16
[task 2022-11-06T23:11:01.666Z] 23:11:01     INFO - PID 6772 | @resource://gre/modules/osfile.jsm:12:30
[task 2022-11-06T23:11:01.667Z] 23:11:01     INFO - PID 6772 | @resource://gre/modules/TelemetryStorage.jsm:19:28
[task 2022-11-06T23:11:01.667Z] 23:11:01     INFO - PID 6772 | removeAbortedSessionPing@resource://gre/modules/TelemetryControllerParent.jsm:735:5
[task 2022-11-06T23:11:01.668Z] 23:11:01     INFO - PID 6772 | removeAbortedSessionPing@resource://gre/modules/TelemetryControllerParent.jsm:249:17
[task 2022-11-06T23:11:01.668Z] 23:11:01     INFO - PID 6772 | shutdownChromeProcess/cleanup/<@resource://gre/modules/TelemetrySession.jsm:1235:42
[task 2022-11-06T23:11:01.669Z] 23:11:01     INFO - PID 6772 | observe@resource://gre/modules/AsyncShutdown.jsm:560:16
[task 2022-11-06T23:11:01.729Z] 23:11:01     INFO - PID 6772 | JavaScript error: resource://gre/modules/AsyncShutdown.jsm, line 703: Error: Phase "profile-before-change" is finished, it is too late to register completion condition "OS.File: flush I/O queued before profileBeforeChange"
[task 2022-11-06T23:11:01.735Z] 23:11:01     INFO - PID 6772 | JavaScript error: resource://gre/modules/AsyncShutdown.jsm, line 703: Error: Phase "profile-before-change" is finished, it is too late to register completion condition "OS.File: flush I/O queued before profileBeforeChange"
[task 2022-11-06T23:11:01.736Z] 23:11:01     INFO - PID 6772 | JavaScript error: resource://gre/modules/AsyncShutdown.jsm, line 703: Error: Phase "profile-before-change" is finished, it is too late to register completion condition "OS.File: flush I/O queued before profileBeforeChange"
[task 2022-11-06T23:11:01.736Z] 23:11:01     INFO - PID 6772 | JavaScript error: resource://gre/modules/AsyncShutdown.jsm, line 703: Error: Phase "profile-before-change" is finished, it is too late to register completion condition "OS.File: flush I/O queued before profileBeforeChange"
[task 2022-11-06T23:11:01.737Z] 23:11:01     INFO - PID 6772 | JavaScript error: resource://gre/modules/AsyncShutdown.jsm, line 703: Error: Phase "profile-before-change" is finished, it is too late to register completion condition "OS.File: flush I/O queued before profileBeforeChange"
[task 2022-11-06T23:11:01.795Z] 23:11:01     INFO - Browser exited with return code 0
[task 2022-11-06T23:11:01.800Z] 23:11:01     INFO - Closing logging queue
[task 2022-11-06T23:11:01.801Z] 23:11:01     INFO - queue closed
[task 2022-11-06T23:11:01.870Z] 23:11:01     INFO - Application command: Z:\task_166777286560419\build\application\firefox\firefox.exe -marionette about:blank --wait-for-browser -profile C:\Users\task_166777286560419\AppData\Local\Temp\tmpbnuk82em
[task 2022-11-06T23:11:01.879Z] 23:11:01     INFO - PID 3884 | 1667776145944	Marionette	INFO	Marionette enabled
[task 2022-11-06T23:11:01.880Z] 23:11:01     INFO - PID 3884 | 1667776145948	Marionette	INFO	Listening on port 49903
[task 2022-11-06T23:11:01.881Z] 23:11:01     INFO - PID 3884 | console.warn: SearchSettings: "get: No settings file exists, new profile?" (new NotFoundError("Could not open the file at C:\\Users\\task_166777286560419\\AppData\\Local\\Temp\\tmpkvt6ahmp\\search.json.mozlz4", (void 0)))
[task 2022-11-06T23:11:01.882Z] 23:11:01     INFO - PID 3884 | *** You are running in background task mode. ***
[task 2022-11-06T23:11:01.883Z] 23:11:01     INFO - PID 3884 | *** You are running in headless mode.
[task 2022-11-06T23:11:01.884Z] 23:11:01     INFO - PID 3884 | console.error: "C:\\Users\\task_166777286560419\\AppData\\Local\\Temp\\tmpkvt6ahmp" "" 0 ".purge.bg_rm"
[task 2022-11-06T23:11:01.884Z] 23:11:01     INFO - Starting runner
[task 2022-11-06T23:11:02.919Z] 23:11:02     INFO - TEST-START | /IndexedDB/idb-explicit-commit.any.worker.html
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → INCOMPLETE
Status: RESOLVED → REOPENED
Resolution: INCOMPLETE → ---
Status: REOPENED → RESOLVED
Closed: 2 years ago2 years ago
Resolution: --- → INCOMPLETE
Status: RESOLVED → REOPENED
Resolution: INCOMPLETE → ---
Status: REOPENED → RESOLVED
Closed: 2 years ago2 years ago
Resolution: --- → INCOMPLETE
Status: RESOLVED → REOPENED
Resolution: INCOMPLETE → ---
Status: REOPENED → RESOLVED
Closed: 2 years ago2 years ago
Resolution: --- → INCOMPLETE
Status: RESOLVED → REOPENED
Resolution: INCOMPLETE → ---

Frequency might have started to increase around here: range

Olli, any chance you could check this out?
Thank you!

Flags: needinfo?(smaug)
Summary: Intermittent /IndexedDB/idb-explicit-commit.any.html | single tracking bug → High frequency /IndexedDB/idb-explicit-commit.any.html | single tracking bug

That hints that this is a real issue somewhere in IDB code. Something there relies on particular GC/CC behavior.

Flags: needinfo?(smaug)
Flags: needinfo?(jvarga)

Update

There have been 55 total failures within the last 7 days:

  • 7 failures on Linux 18.04 WebRender Shippable op
  • 48 failures on Linux 18.04 x64 WebRender debug

Recent log: https://treeherder.mozilla.org/logviewer?job_id=442070823&repo=mozilla-central&lineNumber=2523

Whiteboard: [stockwell disable-recommended] → [stockwell disable-recommended][stockwell needswork]

In the logs for debug builds on CI I see often NS_ERROR_STORAGE_BUSY errors coming from quotamanager.

And the subtest "Transactions that explicitly commit and have errors should abort." which seems to fail now often was already marked to intermittently fail in quite a few cases even before the GC scheduling change
https://searchfox.org/mozilla-central/rev/5f17a6bd35bcce02371973db89bf0196e83b93b6/testing/web-platform/meta/IndexedDB/idb-explicit-commit.any.js.ini#12-20
And based on the .ini file, also other subtests have issues.

Summary: High frequency /IndexedDB/idb-explicit-commit.any.html | single tracking bug → Intermittent /IndexedDB/idb-explicit-commit.any.html | single tracking bug
Whiteboard: [stockwell disable-recommended][stockwell unknown]

We're also failing this test on the interop2024 WPT harness.

I ran the test locally in the verify mode, but it passed successfully.
Forwarding the needinfo to Jari since he is now focusing on interop-2024-indexeddb bugs.

Flags: needinfo?(jvarga) → needinfo?(jjalkanen)
Assignee: nobody → jjalkanen
Flags: needinfo?(jjalkanen)
Attachment #9386898 - Attachment is obsolete: true

This is interesting, bug 1609957 fixed a race condition, but it introduced a dependency on another race. This time, it's a problem with request serial numbers not being in sync between the parent and child. The serial numbers were used only for logging before, now they are also used for explicit commit which is probably not a good idea.
What is even worse, bug 934640 somehow increases the frequency of this intermittent failure, blocking landing of patches for bug 934640.
Now when we know that there's a new race, it's probably not surprising that changes which are not directly related (bug 934640) may affect the frequency of the intermittent failure. It was already mentioned that a small change in GC/CC behavior affects this intermittent failure as well.
I have a WIP patch to fix this and initial testing on try confirms that exact tracking of request/operation ids fixes this intermittent failure.
https://treeherder.mozilla.org/jobs?repo=try&revision=5de97e3b1db8127490a7340f2f2e88aded924e3d

Blocks: 934640
Severity: S4 → S3
Keywords: regression
Priority: P5 → P2
Regressed by: 1609957

Set release status flags based on info from the regressing bug 1609957

Assignee: jjalkanen → jvarga

This patch adds only new member variables, actual support for sending ids will
be added in individual patches (all operations have zero id for now). The idea
is to have only one source of truth, so id used in the parent actor and child
actor is always the same.

Attachment #9390139 - Attachment description: Bug 1799374 - Add initial support for tracking operation ids; r=#dom-storage → Bug 1799374 - Add initial support for tracking request ids; r=#dom-storage

Explicitly committed transactions are aborted in case of a failed request that
was started after committing was initiated. The order of requests is currently
tracked by storing request serial numbers. However, request serial numbers are
not always in sync between parent and child, so they are only suitable for
logging purposes. This patch switches from request serial numbers to request
ids which are only generated by the child side and thus always in sync between
parent and child.

Set release status flags based on info from the regressing bug 1609957

Keywords: leave-open
Pushed by jvarga@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/ebea27b5218c Add initial support for tracking request ids; r=dom-storage-reviewers,asuth https://hg.mozilla.org/integration/autoland/rev/54ace016a4a4 Add support for tracking request ids to normal transaction operations; r=dom-storage-reviewers,asuth https://hg.mozilla.org/integration/autoland/rev/3e941ebd853f Add support for tracking request ids to cursor opening operation; r=dom-storage-reviewers,asuth https://hg.mozilla.org/integration/autoland/rev/7575296d6781 Add support for tracking request ids to cursor continue operation; r=dom-storage-reviewers,asuth
Pushed by jvarga@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/c43bc8bba8a8 Start using request ids for deciding if an explicitly committed transaction needs to be aborted; r=dom-storage-reviewers,asuth
Keywords: leave-open
Pushed by jvarga@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/ff0083c25e3f Require IndexedDB/idb-explicit-commit.any.html to always pass; r=dom-storage-reviewers,asuth
Status: REOPENED → RESOLVED
Closed: 2 years ago1 year ago
Resolution: --- → FIXED
Target Milestone: --- → 126 Branch

Backed out for causing wpt failures in idlharness.https.html.

  • Backout link
  • Push with failures
  • Failure Log
  • Failure line: TEST-UNEXPECTED-PASS | /html/dom/idlharness.https.html?exclude=(Document|Window|HTML.*) | ElementInternals interface: attribute states - expected FAIL
Flags: needinfo?(jvarga)
Blocks: 1887550
Pushed by sstanca@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/730e6cc60956 Require IndexedDB/idb-explicit-commit.any.html to always pass; r=dom-storage-reviewers,asuth

Comment on attachment 9390490 [details]
Bug 1799374 - Require IndexedDB/idb-explicit-commit.any.html to always pass; r=#dom-storage

Revision D204214 was moved to bug 1887550. Setting attachment 9390490 [details] to obsolete.

Attachment #9390490 - Attachment is obsolete: true

Aha, it should not have been backed out.

Flags: needinfo?(jvarga)

Relanded https://hg.mozilla.org/integration/autoland/rev/730e6cc60956749bc49db3c7b2990781c6c40566 as another changeset was the culprit for the failures in Comment 80. Sorry for the confusion!

Attachment #9390490 - Attachment is obsolete: false
Duplicate of this bug: 1887550
No longer blocks: 1887550

The patch landed in nightly and beta is affected.
:janv, is this bug important enough to require an uplift?

  • If yes, please nominate the patch for beta approval.
  • If no, please set status-firefox125 to wontfix.

For more information, please visit BugBot documentation.

Flags: needinfo?(jvarga)

The fix is not trivial, it would be better to let it ride the trains normally (instead of uplifting to beta).

Flags: needinfo?(jvarga)
See Also: → 1785473
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: