1799390 - Thunderbird doesn't warn me about space before .com in email address pill

Status: RESOLVED FIXED

(Thunderbird :: Message Compose Window, defect)

Description

[Michelle]

User Agent: Mozilla/5.0 (Windows NT 6.3; WOW64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/107.0.0.0 Safari/537.36

Steps to reproduce:

I go to send a larger file via attachment

Actual results:

It just hangs. I don't get an error saying it can't be sent or confirmation that it was sent.

It happened to 2 different people. Here's a SS - https://i.imgur.com/OA3HGKk.png

Also, I thought (this is how it used to be) gives you an error when the email address isn't written out correctly & it didn't. It sent the mail.

I copied it from someone & didn't notice there was a space before the .com

Expected results:

I should get errors when large attachments don't send & when the email addy is wrong.

Thanks

Comment 1

[Magnus Melin [:mkmelin]]

Attachment: Bug 1799390 - Improve pill email validation to at least not allow space and double @. r=#thunderbird-reviewers

From https://stackoverflow.com/questions/46155/how-can-i-validate-an-email-address-in-javascript#answer-9204568

Comment 2

[Magnus Melin [:mkmelin]]

I don't know about the send error, but the space before .com we can at least fix.
For the send error, you'd need to get an smtp log. https://wiki.mozilla.org/MailNews:Logging

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/689769bebb35
Improve pill email validation to at least not allow space and double @. r=aleca

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/c3930d867b4a
follow-up, don't require domain name to have dot. rs=bustage-fix

Comment 5

[Thomas D. (:thomas8)]

Hmmm, wearing my QA hat, I think we should continue to accept valid email addresses even if they are weird (see https://stackoverflow.com/a/38787343):

These valid email addresses have both space and @ in the localpart (inside double quotes):

"UX @ its best"@thunderbird.net
"()<>[]:,;@\\"!#$%&'-/=?^_`{}| ~.a"@example.org

Can we improve the regex here to allow such?
Otherwise I'm not sure if error-prevention justifies breaking valid email addresses...

Comment 6

[Magnus Melin [:mkmelin]]

Well, we accept them - they can be used. But you get the warning that it looks invalid.
So IDK. Addresses with space in local part are not going to be used in the wild, and for 99.99999% where this comes up it will be a typo.

Comment 7

[Thomas D. (:thomas8)]

Attachment: Screenshot: Thunderbird now claims that valid email address is not a valid email address (but will send the message anyway)

(In reply to Magnus Melin [:mkmelin] from comment #6)

Well, we accept them - they can be used.

Oh, I see. That's good. Although it's still a bit confusing now that some weird, but valid addresses are marked and claimed to be invalid (see tooltip in screenshot) and send without problems, whereas others are really invalid and might block sending.

But you get the warning that it looks invalid.
So IDK. Addresses with space in local part are not going to be used in the wild, and for 99.99999% where this comes up it will be a typo.

Agreed. So maybe getting just the warning wrong for 0.00001% edge cases is acceptable ;-)

Comment 8

[Magnus Melin [:mkmelin]]

Comment on attachment 9304069 [details]
Bug 1799390 - Improve pill email validation to at least not allow space and double @. r=#thunderbird-reviewers

[Approval Request Comment]
User impact if declined: won't warn about address pills that contain space
Testing completed (on c-c, etc.): beta
Risk to taking this patch (and alternatives if risky): safe

Comment 9

[Wayne Mery (:wsmwk)]

Comment on attachment 9304069 [details]
Bug 1799390 - Improve pill email validation to at least not allow space and double @. r=#thunderbird-reviewers

[Triage Comment]
Approved for esr102

Comment 10

[Rob Lemley [:rjl]]

Thunderbird 102.7.0:
https://hg.mozilla.org/releases/comm-esr102/rev/ef5172fa8594
https://hg.mozilla.org/releases/comm-esr102/rev/ec1f91d74528