1799394 - Minor issue: `Choose User Profile` dialog size changes(flickers)

Status: VERIFIED FIXED

(Toolkit :: Startup and Profile System, defect)

Description

[Alice0775 White]

Steps to reproduce:

1. Start Nightly firefox.exe -p

Actual results:
Choose User Profile dialog flickers.
It will appear wider white window. Immediately after that, it becomes smaller correct size.
Screencast: https://youtu.be/EXjVgFQmJxY

Expected results:
The Choose User Profile dialog should be displayed in the correct size from the beginning without being resized.

Regression window:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=91cb545d28441b51d86fb426145a145a884b3841&tochange=c437eb5573746bf106fe635ae5227cc9b9e83e69

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

:emilio, since you are the author of the regressor, bug 1795224, could you take a look? Also, could you set the severity field?

For more information, please visit auto_nag documentation.

Comment 2

[Emilio Cobos Álvarez (:emilio)]

I can't quite see the flickering, but I guess this is due to this code setting the initial size of the window based on the max-content size which is intentionally bigger than the final size...

Comment 3

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1799394 - Make dialog sizing code consistent between C++ and JS. r=Gijs

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3b36d9afc0a1
Make dialog sizing code consistent between C++ and JS. r=smaug

Comment 5

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/3b36d9afc0a1

Comment 6

[Alice0775 White]

The issue was fixed. No longer reproduce on Nightly109.0a1(20221120214001)